Skip to content

Commit a1e9b48

Browse files
fix(PPP): Use min str size buffer requirements for modem getters (#12688)
* fix(PPP): Use min str size buffer for modem getters * ci(pre-commit): Apply automatic fixes --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
1 parent 0d1ee6d commit a1e9b48

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

libraries/PPP/src/PPP.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include "soc/soc_caps.h"
1414
#include "esp_private/periph_ctrl.h"
1515
#if SOC_PERIPH_CLK_CTRL_SHARED
16-
#define HP_UART_SRC_CLK_ATOMIC() PERIPH_RCC_ATOMIC()
16+
#define HP_UART_SRC_CLK_ATOMIC() PERIPH_RCC_ATOMIC()
1717
#else
1818
#define HP_UART_SRC_CLK_ATOMIC()
1919
#endif
@@ -560,7 +560,7 @@ int PPPClass::BER() const {
560560
String PPPClass::IMSI() const {
561561
PPP_CMD_MODE_CHECK(String());
562562

563-
char imsi[32];
563+
char imsi[CONFIG_ESP_MODEM_C_API_STR_MAX];
564564
esp_err_t err = esp_modem_get_imsi(_dce, imsi);
565565
if (err != ESP_OK) {
566566
log_e("esp_modem_get_imsi failed with %d %s", err, esp_err_to_name(err));
@@ -573,7 +573,7 @@ String PPPClass::IMSI() const {
573573
String PPPClass::IMEI() const {
574574
PPP_CMD_MODE_CHECK(String());
575575

576-
char imei[32];
576+
char imei[CONFIG_ESP_MODEM_C_API_STR_MAX];
577577
esp_err_t err = esp_modem_get_imei(_dce, imei);
578578
if (err != ESP_OK) {
579579
log_e("esp_modem_get_imei failed with %d %s", err, esp_err_to_name(err));
@@ -586,7 +586,7 @@ String PPPClass::IMEI() const {
586586
String PPPClass::moduleName() const {
587587
PPP_CMD_MODE_CHECK(String());
588588

589-
char name[32];
589+
char name[CONFIG_ESP_MODEM_C_API_STR_MAX];
590590
esp_err_t err = esp_modem_get_module_name(_dce, name);
591591
if (err != ESP_OK) {
592592
log_e("esp_modem_get_module_name failed with %d %s", err, esp_err_to_name(err));
@@ -599,7 +599,7 @@ String PPPClass::moduleName() const {
599599
String PPPClass::operatorName() const {
600600
PPP_CMD_MODE_CHECK(String());
601601

602-
char oper[32];
602+
char oper[CONFIG_ESP_MODEM_C_API_STR_MAX];
603603
int act = 0;
604604
esp_err_t err = esp_modem_get_operator_name(_dce, oper, &act);
605605
if (err != ESP_OK) {

0 commit comments

Comments
 (0)