Pass the enabled attributes by value (project-chip#40517)

andy31415 · web-flow · commit 180c8aea6960 · 2025-08-12T14:33:29.000Z
diff --git a/src/app/server-cluster/AttributeListBuilder.cpp b/src/app/server-cluster/AttributeListBuilder.cpp
@@ -23,7 +23,7 @@ namespace app {
 
 CHIP_ERROR AttributeListBuilder::Append(Span<const DataModel::AttributeEntry> mandatoryAttributes,
                                         Span<const DataModel::AttributeEntry> optionalAttributes,
-                                        const AttributeSet & enabledOptionalAttributes)
+                                        AttributeSet enabledOptionalAttributes)
 {
     // determine how much data to append. This should only be called if generally we have something to append
     size_t append_size = mandatoryAttributes.size();
diff --git a/src/app/server-cluster/AttributeListBuilder.h b/src/app/server-cluster/AttributeListBuilder.h
@@ -45,7 +45,7 @@ class AttributeListBuilder
     ///   - optionalAttributes IF AND ONLY IF enabledOptionalAttributes is set for them
     ///   - GlobalAttributes()  (all of them)
     CHIP_ERROR Append(Span<const DataModel::AttributeEntry> mandatoryAttributes,
-                      Span<const DataModel::AttributeEntry> optionalAttributes, const AttributeSet & enabledOptionalAttributes);
+                      Span<const DataModel::AttributeEntry> optionalAttributes, AttributeSet enabledOptionalAttributes);
 
     struct OptionalAttributeEntry
     {

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ namespace app {`
`23`	`23`
`24`	`24`	`CHIP_ERROR AttributeListBuilder::Append(Span<const DataModel::AttributeEntry> mandatoryAttributes,`
`25`	`25`	`Span<const DataModel::AttributeEntry> optionalAttributes,`
`26`		`- const AttributeSet & enabledOptionalAttributes)`
	`26`	`+ AttributeSet enabledOptionalAttributes)`
`27`	`27`	`{`
`28`	`28`	`// determine how much data to append. This should only be called if generally we have something to append`
`29`	`29`	`size_t append_size = mandatoryAttributes.size();`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ class AttributeListBuilder`
`45`	`45`	`/// - optionalAttributes IF AND ONLY IF enabledOptionalAttributes is set for them`
`46`	`46`	`/// - GlobalAttributes() (all of them)`
`47`	`47`	`CHIP_ERROR Append(Span<const DataModel::AttributeEntry> mandatoryAttributes,`
`48`		`- Span<const DataModel::AttributeEntry> optionalAttributes, const AttributeSet & enabledOptionalAttributes);`
	`48`	`+ Span<const DataModel::AttributeEntry> optionalAttributes, AttributeSet enabledOptionalAttributes);`
`49`	`49`
`50`	`50`	`struct OptionalAttributeEntry`
`51`	`51`	`{`