[Part3] Decouple ICD Management cluster to be code driven. (project-chip#41499)

jadhavrohit924 · web-flow · commit 320b10585594 · 2025-11-10T15:12:22.000Z
* Decouple ICD Management cluster to be code driven.

* Add cluster to decoupled list.

* Add codegen integration

* Add unit tests

* Zap regen

* Restyler

* Addressed review comments.

* Fix CI

* Refactor the cluster implementation.

* Reorder member varible for memory holes, validated buffer size before storing to userActiveModeTriggerInstruction

* Rebase and zap regen

* Rebase

* Zap regen

* Address copilot review
diff --git a/examples/air-quality-sensor-app/air-quality-sensor-common/icd-lit-air-quality-sensor-app.matter b/examples/air-quality-sensor-app/air-quality-sensor-common/icd-lit-air-quality-sensor-app.matter
@@ -2851,7 +2851,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
 
     handle command RegisterClient;
     handle command RegisterClientResponse;
diff --git a/examples/all-clusters-app/realtek/data_model/all-clusters-app.matter b/examples/all-clusters-app/realtek/data_model/all-clusters-app.matter
@@ -8272,7 +8272,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 
   server cluster RelativeHumidityMeasurement {
diff --git a/examples/chef/devices/icd_rootnode_contactsensor_ed3b19ec55.matter b/examples/chef/devices/icd_rootnode_contactsensor_ed3b19ec55.matter
@@ -2128,7 +2128,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
 
     handle command RegisterClient;
     handle command RegisterClientResponse;
diff --git a/examples/chef/devices/rootnode_extractorhood_0359bf807d.matter b/examples/chef/devices/rootnode_extractorhood_0359bf807d.matter
@@ -2009,7 +2009,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/closure-app/closure-common/closure-app.matter b/examples/closure-app/closure-common/closure-app.matter
@@ -2424,7 +2424,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/closure-app/silabs/data_model/closure-thread-app.matter b/examples/closure-app/silabs/data_model/closure-thread-app.matter
@@ -2270,7 +2270,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/closure-app/silabs/data_model/closure-wifi-app.matter b/examples/closure-app/silabs/data_model/closure-wifi-app.matter
@@ -2132,7 +2132,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/contact-sensor-app/bouffalolab/data_model/contact-sensor-app.matter b/examples/contact-sensor-app/bouffalolab/data_model/contact-sensor-app.matter
@@ -2326,7 +2326,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
 
     handle command RegisterClient;
     handle command RegisterClientResponse;
diff --git a/examples/contact-sensor-app/nxp/zap-lit/contact-sensor-app.matter b/examples/contact-sensor-app/nxp/zap-lit/contact-sensor-app.matter
@@ -2172,7 +2172,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
 
     handle command RegisterClient;
     handle command RegisterClientResponse;
diff --git a/examples/contact-sensor-app/nxp/zap-sit/contact-sensor-app.matter b/examples/contact-sensor-app/nxp/zap-sit/contact-sensor-app.matter
@@ -2165,7 +2165,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/light-switch-app/light-switch-common/icd-lit-light-switch-app.matter b/examples/light-switch-app/light-switch-common/icd-lit-light-switch-app.matter
@@ -3272,7 +3272,7 @@ endpoint 0 {
     callback attribute operatingMode;
     callback attribute maximumCheckInBackOff;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
 
     handle command RegisterClient;
     handle command RegisterClientResponse;
diff --git a/examples/light-switch-app/light-switch-common/light-switch-app.matter b/examples/light-switch-app/light-switch-common/light-switch-app.matter
@@ -3388,7 +3388,7 @@ endpoint 0 {
     callback attribute activeModeDuration;
     callback attribute activeModeThreshold;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/light-switch-app/qpg/zap/switch.matter b/examples/light-switch-app/qpg/zap/switch.matter
@@ -3198,7 +3198,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
 
     handle command RegisterClient;
     handle command RegisterClientResponse;
diff --git a/examples/light-switch-app/realtek/data_model/light-switch-app-1_to_11.matter b/examples/light-switch-app/realtek/data_model/light-switch-app-1_to_11.matter
@@ -2882,7 +2882,7 @@ endpoint 0 {
     callback attribute activeModeDuration;
     callback attribute activeModeThreshold;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/light-switch-app/realtek/data_model/light-switch-app-1_to_2.matter b/examples/light-switch-app/realtek/data_model/light-switch-app-1_to_2.matter
@@ -3038,7 +3038,7 @@ endpoint 0 {
     callback attribute activeModeDuration;
     callback attribute activeModeThreshold;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/light-switch-app/realtek/data_model/light-switch-app-1_to_8.matter b/examples/light-switch-app/realtek/data_model/light-switch-app-1_to_8.matter
@@ -3038,7 +3038,7 @@ endpoint 0 {
     callback attribute activeModeDuration;
     callback attribute activeModeThreshold;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/light-switch-app/realtek/data_model/light-switch-app.matter b/examples/light-switch-app/realtek/data_model/light-switch-app.matter
@@ -2794,7 +2794,7 @@ endpoint 0 {
     callback attribute activeModeDuration;
     callback attribute activeModeThreshold;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/lighting-app/qpg/zap/light.matter b/examples/lighting-app/qpg/zap/light.matter
@@ -3214,7 +3214,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/lit-icd-app/lit-icd-common/lit-icd-server-app.matter b/examples/lit-icd-app/lit-icd-common/lit-icd-server-app.matter
@@ -2360,7 +2360,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
 
     handle command RegisterClient;
     handle command RegisterClientResponse;
diff --git a/examples/lock-app/lock-common/lock-app.matter b/examples/lock-app/lock-common/lock-app.matter
@@ -3252,7 +3252,7 @@ endpoint 0 {
     callback attribute activeModeDuration;
     callback attribute activeModeThreshold;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/lock-app/nxp/zap/lock-app.matter b/examples/lock-app/nxp/zap/lock-app.matter
@@ -2826,7 +2826,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 1;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/lock-app/qpg/zap/lock.matter b/examples/lock-app/qpg/zap/lock.matter
@@ -3191,7 +3191,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/lock-app/realtek/data_model/lock-app.matter b/examples/lock-app/realtek/data_model/lock-app.matter
@@ -2799,7 +2799,7 @@ endpoint 0 {
     callback attribute activeModeDuration;
     callback attribute activeModeThreshold;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/lock-app/silabs/data_model/lock-app.matter b/examples/lock-app/silabs/data_model/lock-app.matter
@@ -3256,7 +3256,7 @@ endpoint 0 {
     callback attribute activeModeDuration;
     callback attribute activeModeThreshold;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/smoke-co-alarm-app/smoke-co-alarm-common/smoke-co-alarm-app.matter b/examples/smoke-co-alarm-app/smoke-co-alarm-common/smoke-co-alarm-app.matter
@@ -2584,7 +2584,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
 
     handle command RegisterClient;
     handle command RegisterClientResponse;
diff --git a/examples/thermostat/qpg/zap/thermostaticRadiatorValve.matter b/examples/thermostat/qpg/zap/thermostaticRadiatorValve.matter
@@ -3003,7 +3003,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/examples/window-app/common/window-app.matter b/examples/window-app/common/window-app.matter
@@ -2780,7 +2780,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     callback attribute featureMap;
-    ram      attribute clusterRevision default = 3;
+    callback attribute clusterRevision;
   }
 }
 endpoint 1 {
diff --git a/src/BUILD.gn b/src/BUILD.gn
@@ -59,6 +59,7 @@ if (chip_build_tests) {
       "${chip_root}/src/app/clusters/general-commissioning-server/tests",
       "${chip_root}/src/app/clusters/general-diagnostics-server/tests",
       "${chip_root}/src/app/clusters/group-key-mgmt-server/tests",
+      "${chip_root}/src/app/clusters/icd-management-server/tests",
       "${chip_root}/src/app/clusters/network-commissioning/tests",
       "${chip_root}/src/app/clusters/ota-provider/tests",
       "${chip_root}/src/app/clusters/software-diagnostics-server/tests",
diff --git a/src/app/clusters/icd-management-server/BUILD.gn b/src/app/clusters/icd-management-server/BUILD.gn
@@ -16,13 +16,22 @@ import("${chip_root}/src/app/icd/icd.gni")
 
 # transitional dependencies so that chip_data_model sets
 # the right dependencies
-group("icd-management-server") {
+source_set("icd-management-server") {
+  sources = [
+    "ICDManagementCluster.cpp",
+    "ICDManagementCluster.h",
+  ]
   public_deps = [
     "${chip_root}/src/app/icd/server:configuration-data",
     "${chip_root}/src/app/icd/server:icd-server-config",
+    "${chip_root}/src/app/icd/server:observer",
+    "${chip_root}/src/app/server-cluster",
   ]
   if (chip_enable_icd_server) {
-    public_deps += [ "${chip_root}/src/app/icd/server:notifier" ]
+    public_deps += [
+      "${chip_root}/src/app/icd/server:notifier",
+      "${chip_root}/src/app/server",
+    ]
     if (chip_enable_icd_checkin) {
       public_deps += [ "${chip_root}/src/app/icd/server:monitoring-table" ]
     }
diff --git a/src/app/clusters/icd-management-server/CodegenIntegration.cpp b/src/app/clusters/icd-management-server/CodegenIntegration.cpp
@@ -0,0 +1,116 @@
+/**
+ *
+ *    Copyright (c) 2025 Project CHIP Authors
+ *
+ *    Licensed under the Apache License, Version 2.0 (the "License");
+ *    you may not use this file except in compliance with the License.
+ *    You may obtain a copy of the License at
+ *
+ *        http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *    Unless required by applicable law or agreed to in writing, software
+ *    distributed under the License is distributed on an "AS IS" BASIS,
+ *    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *    See the License for the specific language governing permissions and
+ *    limitations under the License.
+ */
+
+#include <app-common/zap-generated/attributes/Accessors.h>
+#include <app/clusters/icd-management-server/ICDManagementCluster.h>
+#include <app/server/Server.h>
+#include <app/static-cluster-config/IcdManagement.h>
+#include <data-model-providers/codegen/ClusterIntegration.h>
+#include <zap-generated/gen_config.h>
+
+namespace {
+using namespace chip;
+using namespace chip::app;
+using namespace chip::app::Clusters;
+using namespace chip::app::Clusters::IcdManagement;
+
+static_assert((IcdManagement::StaticApplicationConfig::kFixedClusterConfig.size() == 1 &&
+               IcdManagement::StaticApplicationConfig::kFixedClusterConfig[0].endpointNumber == kRootEndpointId) ||
+              IcdManagement::StaticApplicationConfig::kFixedClusterConfig.size() == 0);
+
+#if CHIP_CONFIG_ENABLE_ICD_CIP
+LazyRegisteredServerCluster<ICDManagementClusterWithCIP> gServer;
+#else
+LazyRegisteredServerCluster<ICDManagementCluster> gServer;
+#endif
+
+constexpr chip::BitMask<OptionalCommands> kEnabledCommands()
+{
+#if defined(ICD_MANAGEMENT_STAY_ACTIVE_REQUEST_COMMAND)
+    return chip::BitMask<OptionalCommands>(kStayActive);
+#else
+    return chip::BitMask<OptionalCommands>();
+#endif
+}
+
+class IntegrationDelegate : public CodegenClusterIntegration::Delegate
+{
+public:
+    ServerClusterRegistration & CreateRegistration(EndpointId endpointId, unsigned clusterInstanceIndex,
+                                                   uint32_t optionalAttributeBits, uint32_t featureMap) override
+    {
+        ICDManagementCluster::OptionalAttributeSet optionalAttributeSet(optionalAttributeBits);
+        constexpr BitMask<OptionalCommands> enabledCommands = kEnabledCommands();
+
+        // Get UserActiveModeTriggerHint
+        BitMask<IcdManagement::UserActiveModeTriggerBitmap> userActiveModeTriggerHint(0);
+        if (Clusters::IcdManagement::Attributes::UserActiveModeTriggerHint::Get(endpointId, &userActiveModeTriggerHint) !=
+            Protocols::InteractionModel::Status::Success)
+        {
+            ChipLogError(Zcl, "Failed to get UserActiveModeTriggerHint, using default (0)");
+            userActiveModeTriggerHint.ClearAll();
+        }
+
+        // Get UserActiveModeTriggerInstruction
+        char instructionBuffer[kUserActiveModeTriggerInstructionMaxLength];
+        MutableCharSpan instructionSpan(instructionBuffer);
+
+        if (Clusters::IcdManagement::Attributes::UserActiveModeTriggerInstruction::Get(endpointId, instructionSpan) !=
+            Protocols::InteractionModel::Status::Success)
+        {
+            ChipLogError(Zcl, "Failed to get UserActiveModeTriggerInstruction, using default (empty string)");
+            instructionSpan = MutableCharSpan();
+        }
+
+        gServer.Create(endpointId, *Server::GetInstance().GetSessionKeystore(), Server::GetInstance().GetFabricTable(),
+                       ICDConfigurationData::GetInstance(), optionalAttributeSet, enabledCommands, userActiveModeTriggerHint,
+                       instructionSpan);
+        return gServer.Registration();
+    }
+
+    ServerClusterInterface * FindRegistration(unsigned clusterInstanceIndex) override { return &gServer.Cluster(); }
+    void ReleaseRegistration(unsigned clusterInstanceIndex) override { gServer.Destroy(); }
+};
+} // namespace
+
+void MatterIcdManagementClusterInitCallback(EndpointId endpointId)
+{
+    IntegrationDelegate integrationDelegate;
+    CodegenClusterIntegration::RegisterServer(
+        {
+            .endpointId                = endpointId,
+            .clusterId                 = IcdManagement::Id,
+            .fixedClusterInstanceCount = static_cast<uint16_t>(IcdManagement::StaticApplicationConfig::kFixedClusterConfig.size()),
+            .maxClusterInstanceCount   = 1, // only root-node functionality supported by this implementation
+            .fetchFeatureMap           = false,
+            .fetchOptionalAttributes   = true,
+        },
+        integrationDelegate);
+}
+
+void MatterIcdManagementClusterShutdownCallback(EndpointId endpointId)
+{
+    IntegrationDelegate integrationDelegate;
+    CodegenClusterIntegration::UnregisterServer(
+        {
+            .endpointId                = endpointId,
+            .clusterId                 = IcdManagement::Id,
+            .fixedClusterInstanceCount = static_cast<uint16_t>(IcdManagement::StaticApplicationConfig::kFixedClusterConfig.size()),
+            .maxClusterInstanceCount   = 1, // only root-node functionality supported by this implementation
+        },
+        integrationDelegate);
+}
diff --git a/src/app/clusters/icd-management-server/ICDManagementCluster.cpp b/src/app/clusters/icd-management-server/ICDManagementCluster.cpp
diff --git a/src/app/clusters/icd-management-server/ICDManagementCluster.h b/src/app/clusters/icd-management-server/ICDManagementCluster.h
diff --git a/src/app/clusters/icd-management-server/app_config_dependent_sources.cmake b/src/app/clusters/icd-management-server/app_config_dependent_sources.cmake
diff --git a/src/app/clusters/icd-management-server/app_config_dependent_sources.gni b/src/app/clusters/icd-management-server/app_config_dependent_sources.gni
diff --git a/src/app/clusters/icd-management-server/tests/BUILD.gn b/src/app/clusters/icd-management-server/tests/BUILD.gn
diff --git a/src/app/clusters/icd-management-server/tests/TestICDManagementCluster.cpp b/src/app/clusters/icd-management-server/tests/TestICDManagementCluster.cpp
diff --git a/src/app/common/templates/config-data.yaml b/src/app/common/templates/config-data.yaml
diff --git a/src/app/util/util.cpp b/src/app/util/util.cpp
diff --git a/src/app/zap-templates/zcl/zcl-with-test-extensions.json b/src/app/zap-templates/zcl/zcl-with-test-extensions.json
diff --git a/src/app/zap-templates/zcl/zcl.json b/src/app/zap-templates/zcl/zcl.json
diff --git a/zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp b/zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp
diff --git a/zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h b/zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h
diff --git a/zzz_generated/app-common/app-common/zap-generated/callback.h b/zzz_generated/app-common/app-common/zap-generated/callback.h

Original file line number	Diff line number	Diff line change
`@@ -8272,7 +8272,7 @@ endpoint 0 {`
`8272`	`8272`	`callback attribute acceptedCommandList;`
`8273`	`8273`	`callback attribute attributeList;`
`8274`	`8274`	`callback attribute featureMap;`
`8275`		`- ram attribute clusterRevision default = 3;`
	`8275`	`+ callback attribute clusterRevision;`
`8276`	`8276`	`}`
`8277`	`8277`
`8278`	`8278`	`server cluster RelativeHumidityMeasurement {`
Original file line number	Diff line number	Diff line change
`@@ -2009,7 +2009,7 @@ endpoint 0 {`
`2009`	`2009`	`callback attribute acceptedCommandList;`
`2010`	`2010`	`callback attribute attributeList;`
`2011`	`2011`	`callback attribute featureMap;`
`2012`		`- ram attribute clusterRevision default = 3;`
	`2012`	`+ callback attribute clusterRevision;`
`2013`	`2013`	`}`
`2014`	`2014`	`}`
`2015`	`2015`	`endpoint 1 {`
Original file line number	Diff line number	Diff line change
`@@ -2424,7 +2424,7 @@ endpoint 0 {`
`2424`	`2424`	`callback attribute acceptedCommandList;`
`2425`	`2425`	`callback attribute attributeList;`
`2426`	`2426`	`callback attribute featureMap;`
`2427`		`- ram attribute clusterRevision default = 3;`
	`2427`	`+ callback attribute clusterRevision;`
`2428`	`2428`	`}`
`2429`	`2429`	`}`
`2430`	`2430`	`endpoint 1 {`
Original file line number	Diff line number	Diff line change
`@@ -2270,7 +2270,7 @@ endpoint 0 {`
`2270`	`2270`	`callback attribute acceptedCommandList;`
`2271`	`2271`	`callback attribute attributeList;`
`2272`	`2272`	`callback attribute featureMap;`
`2273`		`- ram attribute clusterRevision default = 3;`
	`2273`	`+ callback attribute clusterRevision;`
`2274`	`2274`	`}`
`2275`	`2275`	`}`
`2276`	`2276`	`endpoint 1 {`
Original file line number	Diff line number	Diff line change
`@@ -2132,7 +2132,7 @@ endpoint 0 {`
`2132`	`2132`	`callback attribute acceptedCommandList;`
`2133`	`2133`	`callback attribute attributeList;`
`2134`	`2134`	`callback attribute featureMap;`
`2135`		`- ram attribute clusterRevision default = 3;`
	`2135`	`+ callback attribute clusterRevision;`
`2136`	`2136`	`}`
`2137`	`2137`	`}`
`2138`	`2138`	`endpoint 1 {`
Original file line number	Diff line number	Diff line change
`@@ -2165,7 +2165,7 @@ endpoint 0 {`
`2165`	`2165`	`callback attribute acceptedCommandList;`
`2166`	`2166`	`callback attribute attributeList;`
`2167`	`2167`	`callback attribute featureMap;`
`2168`		`- ram attribute clusterRevision default = 3;`
	`2168`	`+ callback attribute clusterRevision;`
`2169`	`2169`	`}`
`2170`	`2170`	`}`
`2171`	`2171`	`endpoint 1 {`