Skip to content

Commit 6eaa54b

Browse files
authored
ESP32: disable debug mode when compiler optimization assertions are disabled (project-chip#38384) (project-chip#38659)
Earlier we were setting is_debug to TRUE when assertions were disabled and it is incorrect. Earlier we were setting is_debug to TRUE when assertions were disabled and it is incorrect. All components would be built using cmake build system would honour the CONFIG_COMPILER_OPTIMIZATION_ASSERTIONS.... configuration. But sources compiled using gn will have -NDEBUG flag by default. This would create a mismatch.
1 parent 9fca93e commit 6eaa54b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

config/esp32/components/chip/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ endif()
3939

4040
if (NOT CMAKE_BUILD_EARLY_EXPANSION)
4141
if (CONFIG_COMPILER_OPTIMIZATION_ASSERTIONS_DISABLE)
42-
set(is_debug TRUE)
43-
else()
4442
set(is_debug FALSE)
43+
else()
44+
set(is_debug TRUE)
4545
endif()
4646
endif()
4747

0 commit comments

Comments
 (0)