[NXP][platform][common] Avoid using static state variables in OTA firmware processor (project-chip#41944)

Using function local static state variables such as "ulCrtAddr" and
"ulEraseLen" in the OTAFirmwareProcessor::ProcessInternal method causes
issues when OTA transfers are interrupted and then resumed because the
function local variables cannot be accessed (and reset) by other class
methods (such as OTAFirmwareProcessor::Clear or
OTAFirmwareProcessor::AbortAction).

The use of function local state variables was dropped and the SDK
wireless framework OTA support layer is now in charge of managing block
addresses and erases.


Reviewed-by: Dina Benamar <[email protected]>

Signed-off-by: Marian Chereji <[email protected]>

Author: marian-chereji-nxp

src/platform/nxp/common/ota/OTAFirmwareProcessor.cpp

@@ -68,8 +68,6 @@ CHIP_ERROR OTAFirmwareProcessor::Clear()
 CHIP_ERROR OTAFirmwareProcessor::ProcessInternal(ByteSpan & block)
 {
     otaResult_t status;
-    static uint32_t ulEraseLen = 0;
-    static uint32_t ulCrtAddr  = 0;
 
     if (!mDescriptorProcessed)
     {
@@ -102,22 +100,11 @@ CHIP_ERROR OTAFirmwareProcessor::ProcessInternal(ByteSpan & block)
     OTATlvProcessor::vOtaProcessInternalEncryption(mBlock);
 #endif
 
-    ulCrtAddr += block.size();
-
-    if (ulCrtAddr >= ulEraseLen)
-    {
-        ulEraseLen += 0x1000; // flash sector size
-
-        status = OTA_MakeHeadRoomForNextBlock(block.size(), OTAImageProcessorImpl::FetchNextData, 0);
-        if (gOtaSuccess_c != status)
-        {
-            ChipLogError(SoftwareUpdate, "Failed to make room for next block. Status: %d", status);
-            return CHIP_ERROR_OTA_PROCESSOR_MAKE_ROOM;
-        }
-    }
-    else
+    status = OTA_MakeHeadRoomForNextBlock(block.size(), OTAImageProcessorImpl::FetchNextData, 0);
+    if (gOtaSuccess_c != status)
     {
-        OTAImageProcessorImpl::FetchNextData(0);
+        ChipLogError(SoftwareUpdate, "Failed to make room for next block. Status: %d", status);
+        return CHIP_ERROR_OTA_PROCESSOR_MAKE_ROOM;
     }
 
 #if OTA_ENCRYPTION_ENABLE