Skip to content

Commit 7ba3589

Browse files
Rajashreekalmanegemini-code-assist[bot]ukatira
authored
Update PICS for Optional Attributes and Remove Mandatory PICS from script as per test-plan updates (project-chip#40797)
* MINOR CHANGES * Update src/python_testing/TC_TMP_2_1.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * minor changes --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: ukatira <[email protected]>
1 parent b4483e3 commit 7ba3589

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/app/tests/suites/certification/Test_TC_TMP_2_2.yaml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ tests:
3232
value: nodeId
3333

3434
- label: "Step 2: TH reads MinMeasuredValue attribute from DUT"
35-
PICS: TMP.S.A0001
3635
command: "readAttribute"
3736
attribute: "MinMeasuredValue"
3837
response:
@@ -42,7 +41,6 @@ tests:
4241
maxValue: 32766
4342

4443
- label: "Step 3: TH reads MaxMeasuredValue attribute from DUT"
45-
PICS: TMP.S.A0002
4644
command: "readAttribute"
4745
attribute: "MaxMeasuredValue"
4846
response:
@@ -52,7 +50,6 @@ tests:
5250
maxValue: 32767
5351

5452
- label: "Step 4: TH reads MeasuredValue attribute from DUT"
55-
PICS: TMP.S.A0000
5653
command: "readAttribute"
5754
attribute: "MeasuredValue"
5855
response:
@@ -78,7 +75,7 @@ tests:
7875
DUT"
7976
command: "readAttribute"
8077
attribute: "MeasuredValue"
81-
PICS: TMP.S.A0000 && TMP.M.ManuallyControlled
78+
PICS: TMP.M.ManuallyControlled
8279
response:
8380
constraints:
8481
type: int16s

src/python_testing/TC_TMP_2_1.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,11 +105,10 @@ async def test_TC_TMP_2_1(self):
105105
measured_value, max_bound, "Measured value is greater than max bound")
106106

107107
self.step(7)
108-
if await self.attribute_guard(self.get_endpoint(), attr.Tolerance):
108+
if self.pics_guard("TMP.S.A0003"):
109109
tolerance = await self.read_single_attribute_check_success(cluster=cluster, attribute=attr.Tolerance)
110110
asserts.assert_greater_equal(tolerance, 0, "Tolerance is less than 0")
111-
asserts.assert_less_equal(
112-
tolerance, 2048, "Tolerance is greater than 2048")
111+
asserts.assert_less_equal(tolerance, 2048, "Tolerance is greater than 2048")
113112

114113

115114
if __name__ == "__main__":

0 commit comments

Comments
 (0)