nodiscard ChipError Batch project-chip#2: example apps A-F (project-chip#41860)

* Batch project-chip#2 nodiscard errors: example apps A-F

* Fix clang tidy

Author: gmarcosb

examples/air-purifier-app/air-purifier-common/src/air-purifier-manager.cpp

@@ -27,8 +27,8 @@ void AirPurifierManager::Init()
 {
     FanControl::SetDefaultDelegate(mEndpointId, this);
 
-    activatedCarbonFilterInstance.Init();
-    hepaFilterInstance.Init();
+    TEMPORARY_RETURN_IGNORED activatedCarbonFilterInstance.Init();
+    TEMPORARY_RETURN_IGNORED hepaFilterInstance.Init();
     mAirQualitySensorManager.Init();
     mTemperatureSensorManager.Init();
     mHumiditySensorManager.Init();

examples/air-purifier-app/air-purifier-common/src/air-quality-sensor-manager.cpp

@@ -80,23 +80,23 @@ CHIP_ERROR ImmutableReplacementProductListManager::Next(ReplacementProductStruct
     {
     case 0: {
         item.SetProductIdentifierType(ResourceMonitoring::ProductIdentifierTypeEnum::kUpc);
-        item.SetProductIdentifierValue(CharSpan::fromCharString("111112222233"));
+        TEMPORARY_RETURN_IGNORED item.SetProductIdentifierValue(CharSpan::fromCharString("111112222233"));
         break;
     case 1:
         item.SetProductIdentifierType(ResourceMonitoring::ProductIdentifierTypeEnum::kGtin8);
-        item.SetProductIdentifierValue(CharSpan::fromCharString("gtin8xxx"));
+        TEMPORARY_RETURN_IGNORED item.SetProductIdentifierValue(CharSpan::fromCharString("gtin8xxx"));
         break;
     case 2:
         item.SetProductIdentifierType(ResourceMonitoring::ProductIdentifierTypeEnum::kEan);
-        item.SetProductIdentifierValue(CharSpan::fromCharString("4444455555666"));
+        TEMPORARY_RETURN_IGNORED item.SetProductIdentifierValue(CharSpan::fromCharString("4444455555666"));
         break;
     case 3:
         item.SetProductIdentifierType(ResourceMonitoring::ProductIdentifierTypeEnum::kGtin14);
-        item.SetProductIdentifierValue(CharSpan::fromCharString("gtin14xxxxxxxx"));
+        TEMPORARY_RETURN_IGNORED item.SetProductIdentifierValue(CharSpan::fromCharString("gtin14xxxxxxxx"));
         break;
     case 4:
         item.SetProductIdentifierType(ResourceMonitoring::ProductIdentifierTypeEnum::kOem);
-        item.SetProductIdentifierValue(CharSpan::fromCharString("oem20xxxxxxxxxxxxxxx"));
+        TEMPORARY_RETURN_IGNORED item.SetProductIdentifierValue(CharSpan::fromCharString("oem20xxxxxxxxxxxxxxx"));
         break;
     default:
         return CHIP_ERROR_PROVIDER_LIST_EXHAUSTED;

examples/air-purifier-app/air-purifier-common/src/filter-delegates.cpp

@@ -50,10 +50,10 @@ void ApplicationInit()
                                      EndpointId(TEMPERATURE_SENSOR_ENDPOINT), EndpointId(RELATIVE_HUMIDITY_SENSOR_ENDPOINT),
                                      EndpointId(THERMOSTAT_ENDPOINT));
 
-    SetParentEndpointForEndpoint(AIR_QUALITY_SENSOR_ENDPOINT, AIR_PURIFIER_ENDPOINT);
-    SetParentEndpointForEndpoint(TEMPERATURE_SENSOR_ENDPOINT, AIR_PURIFIER_ENDPOINT);
-    SetParentEndpointForEndpoint(RELATIVE_HUMIDITY_SENSOR_ENDPOINT, AIR_PURIFIER_ENDPOINT);
-    SetParentEndpointForEndpoint(THERMOSTAT_ENDPOINT, AIR_PURIFIER_ENDPOINT);
+    SuccessOrDie(SetParentEndpointForEndpoint(AIR_QUALITY_SENSOR_ENDPOINT, AIR_PURIFIER_ENDPOINT));
+    SuccessOrDie(SetParentEndpointForEndpoint(TEMPERATURE_SENSOR_ENDPOINT, AIR_PURIFIER_ENDPOINT));
+    SuccessOrDie(SetParentEndpointForEndpoint(RELATIVE_HUMIDITY_SENSOR_ENDPOINT, AIR_PURIFIER_ENDPOINT));
+    SuccessOrDie(SetParentEndpointForEndpoint(THERMOSTAT_ENDPOINT, AIR_PURIFIER_ENDPOINT));
 }
 
 void ApplicationShutdown()

examples/air-purifier-app/linux/main.cpp

@@ -43,7 +43,7 @@ void emberAfAirQualityClusterInitCallback(chip::EndpointId endpointId)
     chip::BitMask<Feature, uint32_t> airQualityFeatures(Feature::kModerate, Feature::kFair, Feature::kVeryPoor,
                                                         Feature::kExtremelyPoor);
     gAirQualityCluster = new Instance(1, airQualityFeatures);
-    gAirQualityCluster->Init();
+    TEMPORARY_RETURN_IGNORED gAirQualityCluster->Init();
 }
 
 void emberAfAirQualityClusterShutdownCallback(chip::EndpointId endpointId)

examples/all-clusters-app/all-clusters-common/src/air-quality-instance.cpp

@@ -94,14 +94,16 @@ static void BoundDeviceChangedHandler(const Binding::TableEntry & binding, chip:
         if (sSwitchOnOffState)
         {
             Clusters::OnOff::Commands::On::Type onCommand;
-            Controller::InvokeCommandRequest(peer_device->GetExchangeManager(), peer_device->GetSecureSession().Value(),
-                                             binding.remote, onCommand, onSuccess, onFailure);
+            TEMPORARY_RETURN_IGNORED Controller::InvokeCommandRequest(peer_device->GetExchangeManager(),
+                                                                      peer_device->GetSecureSession().Value(), binding.remote,
+                                                                      onCommand, onSuccess, onFailure);
         }
         else
         {
             Clusters::OnOff::Commands::Off::Type offCommand;
-            Controller::InvokeCommandRequest(peer_device->GetExchangeManager(), peer_device->GetSecureSession().Value(),
-                                             binding.remote, offCommand, onSuccess, onFailure);
+            TEMPORARY_RETURN_IGNORED Controller::InvokeCommandRequest(peer_device->GetExchangeManager(),
+                                                                      peer_device->GetSecureSession().Value(), binding.remote,
+                                                                      offCommand, onSuccess, onFailure);
         }
     }
 }
@@ -114,7 +116,7 @@ static void BoundDeviceContextReleaseHandler(void * context)
 static void InitBindingHandlerInternal(intptr_t arg)
 {
     auto & server = chip::Server::GetInstance();
-    Binding::Manager::GetInstance().Init(
+    TEMPORARY_RETURN_IGNORED Binding::Manager::GetInstance().Init(
         { &server.GetFabricTable(), server.GetCASESessionManager(), &server.GetPersistentStorage() });
     Binding::Manager::GetInstance().RegisterBoundDeviceChangedHandler(BoundDeviceChangedHandler);
     Binding::Manager::GetInstance().RegisterBoundDeviceContextReleaseHandler(BoundDeviceContextReleaseHandler);
@@ -126,7 +128,7 @@ CHIP_ERROR InitBindingHandlers()
     // so it requires the Server instance to be correctly initialized. Post the init function to
     // the event queue so that everything is ready when initialization is conducted.
     // TODO: Fix initialization order issue in Matter server.
-    chip::DeviceLayer::PlatformMgr().ScheduleWork(InitBindingHandlerInternal);
+    TEMPORARY_RETURN_IGNORED chip::DeviceLayer::PlatformMgr().ScheduleWork(InitBindingHandlerInternal);
 #if defined(ENABLE_CHIP_SHELL)
     RegisterSwitchCommands();
 #endif

examples/all-clusters-app/all-clusters-common/src/binding-handler.cpp

@@ -32,12 +32,12 @@ bool HandleBooleanStateConfigurationTestEventTrigger(uint64_t eventTrigger)
     {
     case BooleanStateConfigurationTrigger::kSensorTrigger:
         ChipLogProgress(Support, "[BooleanStateConfiguration-Test-Event] => Trigger sensor");
-        SetAllEnabledAlarmsActive(1);
+        TEMPORARY_RETURN_IGNORED SetAllEnabledAlarmsActive(1);
         break;
 
     case BooleanStateConfigurationTrigger::kSensorUntrigger:
         ChipLogProgress(Support, "[BooleanStateConfiguration-Test-Event] => Untrigger sensor");
-        ClearAllAlarms(1);
+        TEMPORARY_RETURN_IGNORED ClearAllAlarms(1);
         break;
 
     default:

examples/all-clusters-app/all-clusters-common/src/boolcfg-stub.cpp

@@ -146,7 +146,7 @@ void emberAfActionsClusterInitCallback(EndpointId endpoint)
     sActionsDelegateImpl = std::make_unique<Actions::ActionsDelegateImpl>();
     sActionsServer       = std::make_unique<Actions::ActionsServer>(endpoint, *sActionsDelegateImpl.get());
 
-    sActionsServer->Init();
+    TEMPORARY_RETURN_IGNORED sActionsServer->Init();
 }
 
 void emberAfActionsClusterShutdownCallback(EndpointId endpoint)

examples/all-clusters-app/all-clusters-common/src/bridged-actions-stub.cpp

@@ -80,7 +80,7 @@ Status AVSettingsUserLevelManagementDelegate::MPTZSetPosition(Optional<int16_t>
     // the callback. The server itself will persist the new values.
     //
     mCallback = callback;
-    DeviceLayer::SystemLayer().StartTimer(System::Clock::Seconds16(2), onTimerExpiry, this);
+    TEMPORARY_RETURN_IGNORED DeviceLayer::SystemLayer().StartTimer(System::Clock::Seconds16(2), onTimerExpiry, this);
 
     return Status::Success;
 }
@@ -93,7 +93,7 @@ Status AVSettingsUserLevelManagementDelegate::MPTZRelativeMove(Optional<int16_t>
     // the callback. The server itself will persist the new values.
     //
     mCallback = callback;
-    DeviceLayer::SystemLayer().StartTimer(System::Clock::Seconds16(2), onTimerExpiry, this);
+    TEMPORARY_RETURN_IGNORED DeviceLayer::SystemLayer().StartTimer(System::Clock::Seconds16(2), onTimerExpiry, this);
 
     return Status::Success;
 }
@@ -106,7 +106,7 @@ Status AVSettingsUserLevelManagementDelegate::MPTZMoveToPreset(uint8_t aPreset,
     // movements, invoke the callback. The server itself will persist the new values.
     //
     mCallback = callback;
-    DeviceLayer::SystemLayer().StartTimer(System::Clock::Seconds16(2), onTimerExpiry, this);
+    TEMPORARY_RETURN_IGNORED DeviceLayer::SystemLayer().StartTimer(System::Clock::Seconds16(2), onTimerExpiry, this);
 
     return Status::Success;
 }
@@ -235,12 +235,12 @@ void emberAfCameraAvSettingsUserLevelManagementClusterInitCallback(chip::Endpoin
 
     gAVSettingsUserLevelManagementCluster = std::make_unique<CameraAvSettingsUserLevelMgmtServer>(
         kEndpointId, *gDelegate.get(), avsumFeatures, avsumAttrs, appMaxPresets);
-    gAVSettingsUserLevelManagementCluster->Init();
+    TEMPORARY_RETURN_IGNORED gAVSettingsUserLevelManagementCluster->Init();
 
     // Set app specific limits to pan, tilt, zoom
-    gAVSettingsUserLevelManagementCluster->SetPanMin(appPanMin);
-    gAVSettingsUserLevelManagementCluster->SetPanMax(appPanMax);
-    gAVSettingsUserLevelManagementCluster->SetTiltMin(appTiltMin);
-    gAVSettingsUserLevelManagementCluster->SetTiltMax(appTiltMax);
-    gAVSettingsUserLevelManagementCluster->SetZoomMax(appZoomMax);
+    TEMPORARY_RETURN_IGNORED gAVSettingsUserLevelManagementCluster->SetPanMin(appPanMin);
+    TEMPORARY_RETURN_IGNORED gAVSettingsUserLevelManagementCluster->SetPanMax(appPanMax);
+    TEMPORARY_RETURN_IGNORED gAVSettingsUserLevelManagementCluster->SetTiltMin(appTiltMin);
+    TEMPORARY_RETURN_IGNORED gAVSettingsUserLevelManagementCluster->SetTiltMax(appTiltMax);
+    TEMPORARY_RETURN_IGNORED gAVSettingsUserLevelManagementCluster->SetZoomMax(appZoomMax);
 }

examples/all-clusters-app/all-clusters-common/src/camera-av-settings-user-level-management-stub.cpp

@@ -390,7 +390,7 @@ void emberAfCameraAvStreamManagementClusterInitCallback(EndpointId endpoint)
         sensorParams, nightVisionUsesInfrared, minViewport, rateDistortionTradeOffPoints, maxContentBufferSize, micCapabilities,
         spkrCapabilities, twowayTalkSupport, snapshotCapabilities, maxNetworkBandwidth, supportedStreamUsages,
         streamUsagePriorities);
-    sCameraAVStreamMgmtClusterServerInstance->Init();
+    TEMPORARY_RETURN_IGNORED sCameraAVStreamMgmtClusterServerInstance->Init();
 }
 
 void emberAfCameraAvStreamManagementClusterShutdownCallback(EndpointId endpoint)