Decouple TimeFormatLocalization cluster (project-chip#40148)

* Add initial TimeFormatLocalization decoupling

* Add comments and changes to build test file

* Add code improvements from internal feedback

* Add FeatureFlags handling

* Add changes to UnitTests

* Add test persistence implementation

* minor code fixes

* revert local testing changes un python build

* Move WriteAttribute to Logic layer

* Start Read/Write UnitTest implementation using AttributePersistenceProvider

* Update tests cases

* Restyled by whitespace

* Restyled by clang-format

* reorganize code and add basic validations

* Restyled by whitespace

* Restyled by clang-format

* Change initialization list in constructor

* Restyled by whitespace

* Restyled by clang-format

* Reduce SampleProvider complexity and size for UnitTests

* Add unit test for invalid values

* Minor changes for constant elements

* Add changes for AttributeListBuilder

* Changes to AttributePersistenceProvider in Logic

* Fix failures in unit test due change in Setters

* Removed ember related callbacks

* Change BitFlags initialization in Tests

* Change include header format

* Remove curly braces from switch statements when applicable

* test integration of AttributePersistence

* Combine change individual setter to a combined attribute handler in Logic

* Removed test logs, and simplified code

* Change zap generation for ClusterRevision

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Restyled by prettier-json

* Remove breaking UnitTest

* Change ember callbacks

* Change calendar setter to avoid double decoding

* Fix ActiveCalendarType not being stored properly

* Remove test changes

* Restyled by whitespace

* Restyled by clang-format

* Change type of AttributePersistenProvider in Logic layer

* Regenerate ZAP code

* Move logic to cluster

* Remove unused files

* Add fixes from PR comments

* Remove additional logic for return error values

* Change attributelist logic

* Change default value handling for attributes

* Revert ZAP changes for attributes

* Adjust UnitTest for Cluster only layer implementation

* Regenerate files with ZAP

* Restyled by whitespace

* Restyled by clang-format

* Add review fixes

* Revert changes to AttributePersistence

* minor changes from review

* Restyled by whitespace

* Regenerate ZAP files

* Add validation for empty Calendar list

* Change error code for ReadAttribute

* Update copyright dates for files that use partially the old implementation

* Regenerate ZAP files

* Slight updates for smaller code (30 bytes saved it seems)

* Update for slightly smaller code, fix some logic and copyright.

* Fix load/store logic a bit more.

* Restyle

* Update src/app/clusters/time-format-localization-server/time-format-localization-cluster.cpp

* Fix logic to select a supported calendar.

ZAP files seem to use defaults (i.e. 0 i.e. budhist calendar)
which is wrong, but we must handle.

* Restyle

* Fix new callbacks for code driven clusters.

* Undo the bad merge of shutdown functions.
Sort the code driven cluster list.

* Standardize the startup/shutdown for time format localization.

This saves a bit of flash.

* ZAP Regen and minor style update.

* Update src/app/clusters/time-format-localization-server/time-format-localization-cluster.cpp

---------

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>

Author: 4 people

examples/all-clusters-app/all-clusters-common/all-clusters-app.matter

@@ -7716,14 +7716,14 @@ endpoint 0 {
   }
 
   server cluster TimeFormatLocalization {
-    persist  attribute hourFormat default = 0;
-    persist  attribute activeCalendarType default = 0;
+    ram      attribute hourFormat default = 0;
+    ram      attribute activeCalendarType default = 0;
     callback attribute supportedCalendarTypes;
     callback attribute generatedCommandList;
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     ram      attribute featureMap default = 1;
-    ram      attribute clusterRevision default = 1;
+    callback attribute clusterRevision;
   }
 
   server cluster UnitLocalization {

examples/all-clusters-app/all-clusters-common/all-clusters-app.zap

@@ -1425,7 +1425,7 @@
               "side": "server",
               "type": "HourFormatEnum",
               "included": 1,
-              "storageOption": "NVM",
+              "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
               "defaultValue": "0",
@@ -1441,7 +1441,7 @@
               "side": "server",
               "type": "CalendarTypeEnum",
               "included": 1,
-              "storageOption": "NVM",
+              "storageOption": "RAM",
               "singleton": 0,
               "bounded": 0,
               "defaultValue": "0",
@@ -1537,10 +1537,10 @@
               "side": "server",
               "type": "int16u",
               "included": 1,
-              "storageOption": "RAM",
+              "storageOption": "External",
               "singleton": 0,
               "bounded": 0,
-              "defaultValue": "1",
+              "defaultValue": null,
               "reportable": 1,
               "minInterval": 1,
               "maxInterval": 65534,

examples/all-clusters-app/realtek/data_model/all-clusters-app.matter

@@ -7895,7 +7895,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     ram      attribute featureMap default = 1;
-    ram      attribute clusterRevision default = 1;
+    callback attribute clusterRevision;
   }
 
   server cluster UnitLocalization {

examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter

@@ -6525,7 +6525,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     ram      attribute featureMap default = 0;
-    ram      attribute clusterRevision default = 1;
+    callback attribute clusterRevision;
   }
 
   server cluster UnitLocalization {

examples/bridge-app/bridge-common/bridge-app.matter

@@ -2324,7 +2324,7 @@ endpoint 0 {
     callback attribute acceptedCommandList;
     callback attribute attributeList;
     ram      attribute featureMap default = 0;
-    ram      attribute clusterRevision default = 1;
+    callback attribute clusterRevision;
   }
 
   server cluster UnitLocalization {

examples/tv-app/tv-common/tv-app.matter

@@ -3712,7 +3712,7 @@ endpoint 0 {
     persist  attribute activeCalendarType default = 0;
     callback attribute supportedCalendarTypes;
     ram      attribute featureMap default = 0;
-    ram      attribute clusterRevision default = 1;
+    callback attribute clusterRevision;
   }
 
   server cluster UnitLocalization {

examples/tv-casting-app/tv-casting-common/tv-casting-app.matter

@@ -3087,7 +3087,7 @@ endpoint 0 {
     persist  attribute activeCalendarType default = 0;
     callback attribute supportedCalendarTypes;
     ram      attribute featureMap default = 0;
-    ram      attribute clusterRevision default = 1;
+    callback attribute clusterRevision;
   }
 
   server cluster UnitLocalization {

examples/virtual-device-app/virtual-device-common/virtual-device-app.matter

@@ -3673,7 +3673,7 @@ endpoint 0 {
     persist  attribute activeCalendarType default = 0;
     callback attribute supportedCalendarTypes;
     ram      attribute featureMap default = 0;
-    ram      attribute clusterRevision default = 1;
+    callback attribute clusterRevision;
   }
 
   server cluster UnitLocalization {

scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/CodeDrivenCallback.h

@@ -31,6 +31,10 @@ void MatterBasicInformationClusterInitCallback(chip::EndpointId endpointId);
 
 void MatterBasicInformationClusterShutdownCallback(chip::EndpointId endpointId);
 
+void MatterTimeFormatLocalizationClusterInitCallback(chip::EndpointId endpointId);
+
+void MatterTimeFormatLocalizationClusterShutdownCallback(chip::EndpointId endpointId);
+
 void MatterGeneralDiagnosticsClusterInitCallback(chip::EndpointId endpointId);
 
 void MatterGeneralDiagnosticsClusterShutdownCallback(chip::EndpointId endpointId);

scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/CodeDrivenInitShutdown.cpp

@@ -33,6 +33,9 @@ void MatterClusterServerInitCallback(EndpointId endpoint, ClusterId clusterId)
     case app::Clusters::BasicInformation::Id:
         MatterBasicInformationClusterInitCallback(endpoint);
         break;
+    case app::Clusters::TimeFormatLocalization::Id:
+        MatterTimeFormatLocalizationClusterInitCallback(endpoint);
+        break;
     case app::Clusters::GeneralDiagnostics::Id:
         MatterGeneralDiagnosticsClusterInitCallback(endpoint);
         break;
@@ -67,6 +70,9 @@ void MatterClusterServerShutdownCallback(EndpointId endpoint, ClusterId clusterI
     case app::Clusters::BasicInformation::Id:
         MatterBasicInformationClusterShutdownCallback(endpoint);
         break;
+    case app::Clusters::TimeFormatLocalization::Id:
+        MatterTimeFormatLocalizationClusterShutdownCallback(endpoint);
+        break;
     case app::Clusters::GeneralDiagnostics::Id:
         MatterGeneralDiagnosticsClusterShutdownCallback(endpoint);
         break;