Skip to content

Commit f634285

Browse files
authored
Docstring Updates: Run mypy on ChipDeviceCtrl.py and fix errors (excluding external deps) (project-chip#39519)
* Initial commit: Added docstring with type hints to ConnectBLE method. * Updated docstring with type hints to ConnectBLE method. * Updated docstring with type hints to classes ChipDeviceController ,ChipDeviceControllerBase ,BareChipDeviceController, and CommissioningWindowPasscode. * Fixed: Updated Parameters to Args in docstring to aling with style. * Updated docstrings for non-obvious required parameters. * Updated docstrings Optional Args. * Fixed: Updated docstrings based on feedback v2. * Fixed: Updated method create_native_object to correct one _create_native_object. * Fixed: Adding None check for symmetricKey before using len. * Fixed: Updated fabricAdmin to return Optional type. * Fixed: Added assert fabricAdmin is not None. * Fixed: Added assert fabricAdmin is not None, must be provided v2. * Fixed: Added ignore[attr-defined] on chipStack since it is set dynamically. * Fixed: Added ignore[attr-defined] on 'value' since it is set dynamically on ClusterAttributeDescriptor. * Fixed: Added ignore[arg-type and misc] due to valid use of dynamic types, intentional None, and flexible tuple formats. * Fixed: Added ignore[arg-type] due to bypass mypy errors caused by intentional dynamic typing. * Fixed: Added ignore[arg-type] due to bypass mypy errors caused by intentional dynamic typing v2. * Fixed: Added ignore[arg-type] due to bypass mypy errors caused by intentional dynamic typing v3. * Fixed: Added assert to check devCtrl is not None before calling SendGroupCommand. * Fixed: Added assert to check devCtrl is not None before WriteGroupAttributes. * Fixed: Added ignore[return-value] to bypass mypy error due to coroutine returned without await. * Fixed: Added ignore[attr-defined] for 'chipStack'; dynamically set at runtime (see __del__ method in DeviceProxyWrapper). * Fixed: Updates based on code review feedback.
1 parent 2685869 commit f634285

File tree

1 file changed

+95
-39
lines changed

1 file changed

+95
-39
lines changed

0 commit comments

Comments
 (0)