test: detect when hugo server is ready and start checking

Author: f-hollow

.github/workflows/cron-check-int-links.yml

@@ -39,8 +39,11 @@ jobs:
 
       - name: Start Hugo server
         run: |
-          nohup hugo server -p 1313 &
-          sleep 5  # Wait for server to start
+          hugo server --port 1313 >/dev/null 2>&1 &
+          until curl -fs http://localhost:1313/ >/dev/null 2>&1; do
+            sleep 0.2
+          done
+          echo "Hugo is ready"
 
       - name: Check internal links
         id: linkcheck
@@ -50,18 +53,25 @@ jobs:
             /BROKEN/ { cluster=cluster $0 "\n"; next }
             /^Finished!/ { if(cluster) { printf "%s\n%s\n", header, cluster } }
           ')
-          echo ""
-          echo "$broken"
+
+          printf "%s\n" "$broken"
+
           echo "broken<<EOF" >> $GITHUB_ENV
           echo "$broken" >> $GITHUB_ENV
           echo "EOF" >> $GITHUB_ENV
 
-      - name: Stop Hugo server
-        run: |
-          pkill -f "hugo server"
+          if [ -n "$broken" ]; then
+            echo "Broken internal links detected"
+            exit 1
+          fi
 
       - name: Suggestions
-        if: env.broken != ''
+        if: failure()
         run: |
           echo -e "\nPlease review the links reported in Check internal links step above.\n"
           exit 1
+
+      - name: Stop Hugo server
+        if: always()
+        run: |
+          pkill -f "hugo server"