Skip to content

Conversation

@FBEZ
Copy link
Collaborator

@FBEZ FBEZ commented Feb 24, 2025

This pull request adds the first part of the two part article series "http server".

Description

The article "top layer" which isn't shown in the "recent" section is here .
The first part can be found on the "recent" section.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@pedrominatel pedrominatel self-requested a review March 25, 2025 11:37
Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @FBEZ. Here are my initial comments.

Copy link
Collaborator

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FBEZ Thank you for writing the tutorial. I left a few questions and some suggestions. Once you respond to them, I will do another review.

@FBEZ
Copy link
Collaborator Author

FBEZ commented Apr 3, 2025

I restructured the article to be stand-alone. This way there is no the problem of the featured image.
I improved the structure, changed the pronouns from you to we were deemed useful.

@FBEZ
Copy link
Collaborator Author

FBEZ commented Apr 9, 2025

I implemented all the changes.
What's missing is the title series and the rendering of the repo (which hopefully now works).

Copy link
Collaborator

@f-hollow f-hollow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FBEZ A couple of nitpicks. Otherwise, LGTM!

@FBEZ
Copy link
Collaborator Author

FBEZ commented Apr 10, 2025

I implemented the changes and squashed the commits.
As a title I used ESP-IDF Tutorial Series: Soft-AP - Access Point with Espressif

@f-hollow
Copy link
Collaborator

I implemented the changes and squashed the commits. As a title I used ESP-IDF Tutorial Series: Soft-AP - Access Point with Espressif

with Espressif reads like the company will help you set up the AP.

As an idea, how about:

ESP-IDF Tutorials: Soft-AP - Access Point on Espressif <SoC/module/etc.>

@FBEZ
Copy link
Collaborator Author

FBEZ commented Apr 11, 2025

In the end I think it's best to keep the title short. I put the agreed ESP-IDF Tutorials: Soft-AP 😄

Copy link
Member

@pedrominatel pedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FBEZ, LTGM!

@@ -0,0 +1,369 @@
---
title: "ESP-IDF Tutorials: Soft-AP"
date: 2025-04-11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the date to date: 2025-04-18.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

4. Configure and launch a soft-AP, allowing devices to connect via Wi-Fi.
5. Verify event handling by monitoring the terminal for connection events.

This serves as a foundation for building more advanced Wi-Fi applications, such as MQTT clients, HTTP servers, or other networked solutions. No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding the ESP32-C6 workshop as additional material.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@pedrominatel pedrominatel merged commit bbedd51 into espressif:main Apr 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants