feat: improve website header layout #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
It looks fine to me now! |
FBEZ
approved these changes
Mar 7, 2025
pedrominatel
reviewed
Mar 7, 2025
config/_default/languages.cs.toml
Outdated
| languageName = "Czech" | ||
| weight = 1 | ||
| title = "Developer Portal" | ||
| title = "Espressif Developer Portal" |
Member
There was a problem hiding this comment.
Remove Espressif and keep Developer Portal.
Collaborator
Author
There was a problem hiding this comment.
Done.
May I ask why we omit the company name in the Czech version?
Member
There was a problem hiding this comment.
Kirill, the logo with Espressif written using a different font from the original version does not align with our logo guidelines.
We can keep the logo plus the Developer Portal only or change the logo to include the version with the logo on the top and Espressif on the bottom, which will add more space on the top.
Member
There was a problem hiding this comment.
This should be not for the CZ version but for all languages we will support in the future.
f-hollow
force-pushed
the
feat/improve_website_header_layout
branch
from
f9235ce to
e5f679f
Compare
Collaborator
Author
|
@pedrominatel PTAL again |
pedrominatel
approved these changes
Mar 10, 2025
f-hollow
force-pushed
the
feat/improve_website_header_layout
branch
from
bbe7bcc to
0337416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the Developer Portal's header layout.
To preview how it looks on a mobile device, use your browser's mobile view mode. For example, Firefox has the the Responsive Design Mode.
However, the CI job adds a link back to this PR in the header of the preview website. Maybe the best way to visualize the header changes is on your local machine.
What has been updated
Espressif Developer Portalin the header was reduced toDeveloper Portal. This saves horizontal space and removes the duplication of the word Espressif in the logo andEspressif Developer PortalFollow-up actions
See issue #161.
Related
Testing
Done locally.
Checklist
Before submitting a Pull Request, please ensure the following: