Skip to content

Conversation

@FBEZ
Copy link
Collaborator

@FBEZ FBEZ commented Mar 28, 2025

Reviewed internally


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@FBEZ FBEZ added the GitLab-Sync-Merge Contribution reviewed and synced from the internal GitLab mirror label Mar 28, 2025
@FBEZ FBEZ force-pushed the blog/add_esp32-h2_knob branch from ed278aa to 11d820a Compare March 28, 2025 11:01
@f-hollow f-hollow merged commit f4ab2bc into espressif:main Mar 28, 2025
6 checks passed
The examples are
* **BLE-HID**: A BLE-HID implementation based on the [ble_hid_device_demo](https://github.com/espressif/esp-idf/tree/release/v5.4/examples/bluetooth/bluedroid/ble/ble_hid_device_demo). You can adjust the volume by turning the knob and change the bonded device through a long press.
* **BTHome firmware**: It integrates `Button`and `Dimmer`components, broadcasting the data in BTHome protocol. It supports Home Assistant and automatic deep sleep.
* **Matter universal switch**: It implements a simple matter switch, which can be provisioned using the netword qr-code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, network.

Maybe we can add a spell checker as a pre-commit hook or as a Github PR review step.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @igrr!

@pedrominatel pedrominatel mentioned this pull request Mar 28, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GitLab-Sync-Merge Contribution reviewed and synced from the internal GitLab mirror

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants