-
Notifications
You must be signed in to change notification settings - Fork 43
Add blog-post on esp-wifi-remote #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog-post on esp-wifi-remote #546
Conversation
mantriyogesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks fantastic.
- Some refinements might be needed.
- Top image could be simpler and intuitive.
Thanks for the valuable comments, I'll think about that featured picture (and still need to make some edits, mainly to pictures) Also, wanted to use some common terminology for the "RPC library", any idea? I sometimes use "RPC implementation component", "RPC library" or "RPC implementor lib"... |
|
@glmfe @euripedesrocha PTAL |
2028558 to
e27b8b8
Compare
euripedesrocha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments.
Nice article!
Thanks for the review and comments! |
|
In |
Very good point, thanks! Have added (+ added the custom option, which is also available) |
8d278df to
8b161b9
Compare
|
Thanks for the review @euripedesrocha @mantriyogesh ! @f-hollow PTAL |
pedrominatel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @david-cermak, please find my comments. Thank you for your collaboration!
Thanks for taking a look! Fixed as suggested, just kept one discussion open -> please resolve if it sound good to you. |
6f672ed to
e997cbc
Compare
f-hollow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@david-cermak Thank you for writing the article!
I have a few comments that generally try to uphold the following principles:
- Refer to things in the same way or use unified terminology in the article. One example is
WiFi-lessvs.WiFi-enabledvs.WiFi-capable, or local WiFi vs. native WiFi, etc. - Create a narrative so that the text evolves from one topic or idea to another. This helps avoid repeating the same facts in different combinations.
I reviewed the article up until the heading WiFi Remote component breakdown.
I will continue my review tomorrow.
079053b to
091bc69
Compare
f-hollow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nitpicks. Otherwise, LGTM!
|
@f-hollow @pedrominatel Thank you for the review and your valuable suggestions! |
7caca53 to
3aee044
Compare
3aee044 to
ee75755
Compare
Description