-
Notifications
You must be signed in to change notification settings - Fork 43
feat: add micropython in the browser workshop #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - In the ESP Control Panel, click `Disconnect device`, then reopen the notebook and connect again. | ||
|
|
||
| ## Feedback | ||
| If you have feedback for this workshop, please feel free to contact me at [[email protected]](mailto:[email protected]) 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not share your email here. You can do it during the workshop, only for the participants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, thank you for suggestion!
|
Hi @XDanielPaul , thank you for the interesting workshop! I'll proceed with the review today. In the meanwhile, please split this single page workshop. Consider splitting it into:
You can check the structure of the other workshops: |
Thank you for taking a look! I've updated the workshop according to your suggestions apart from renaming the introductory page from |
FBEZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few suggestions.
Two main themes:
- I would focus on the ESP32-C3-DevKit-RUST-2 board, giving all the commands for this board (instead of generic ESP32). I think it makes things more clear. You can always say that the procedure can be easily adapted to any ESP32 family SoC
- Avoid repeating the workshop title on each page.
- I feel there are some parts a bit too terse and some additional text may help.
You can find everything in the comments.
content/workshops/micropython-jupyter-notebooks-in-browser/assignment-4/index.md
Show resolved
Hide resolved
FBEZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few suggestions.
Two main themes:
- I would focus on the ESP32-C3-DevKit-RUST-2 board, giving all the commands for this board (instead of generic ESP32). I think it makes things more clear. You can always say that the procedure can be easily adapted to any ESP32 family SoC
- Avoid repeating the workshop title on each page.
- I feel there are some parts a bit too terse and some additional text may help.
You can find everything in the comments.
|
@f-hollow, can you please take a look? |
|
@FBEZ Thank you for a thorough review! I addressed the changes and pushed them yesterday. I left one question to your comment could you please take a look? |
f-hollow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XDanielPaul Thank you for your contribution.
I left a few comments and suggestions. Please also go over the non-implemented comments from Francesco.
Sorry again for some inconvenience with our workshop formatting. We will fix it soon!
4f4c463 to
f0262da
Compare
| ### Flashing MicroPython Firmware | ||
|
|
||
| 1. Connect your ESP32-C3-DevKit-RUST-2 development board to your computer via USB cable | ||
| 2. Open your Chromium-based browser and navigate to the [website](https://xdanielpaul.github.io/jupyter-lite-micropython/lab/index.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can host is somewhere on Espressif servers (or on Espressif's GitHub)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I would also like to update the MQTT Broker in Assignment 4 to use ours, do we have something like that publicly available or should I make a deployment for one?
Our Hugo theme has a brief description of the series parameters. You need to pick a unique identifier for the series and assign consecutive numbers to each article in the series. The main page |
| - On Linux or MacOS run command `mosquitto_sub -h test.mosquitto.org -t "esp32/orientation"` in your terminal to subscribe to the topic | ||
| - On Windows you will need to add mosquitto to your PATH environment variable or navigate to the path where the executable is located (usually `C:\Program Files\mosquitto\`) and run `mosquitto_sub.exe -h test.mosquitto.org -t "esp32/orientation"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - On Linux or MacOS run command `mosquitto_sub -h test.mosquitto.org -t "esp32/orientation"` in your terminal to subscribe to the topic | |
| - On Windows you will need to add mosquitto to your PATH environment variable or navigate to the path where the executable is located (usually `C:\Program Files\mosquitto\`) and run `mosquitto_sub.exe -h test.mosquitto.org -t "esp32/orientation"` | |
| - On **Linux** or **MacOS**, run command `mosquitto_sub -h test.mosquitto.org -t "esp32/orientation"` in your terminal to subscribe to the topic | |
| - On **Windows**, you will need to add mosquitto to your `PATH` environment variable or navigate to the path where the executable is located (usually `C:\Program Files\mosquitto\`) and run `mosquitto_sub.exe -h test.mosquitto.org -t "esp32/orientation"` |
|
@XDanielPaul Thank you for incorporating the feedback. I left a couple of suggestions regarding my previous comments, one regarding article heading levels (that became obvious once you enabled TOCs), and only one new comment regarding the URL slug (sorry , I didn't notice it before, and it is quite important). Once you fix these, I am ready to approve your PR. |
|
@XDanielPaul well done, good luck with your workshop! |
Description
This MR introduces a workshop for ESP Community event with the theme MicroPython Jupyter in the Browser with ESP32-C3
Link to assignments
https://xdanielpaul.github.io/jupyter-lite-micropython/lab/index.html
Related