added red-da compliant matter devices with esp-zerocode - Anant #598
Conversation
FBEZ
force-pushed
the
red_da_esp_zerocode
branch
from
8d5304b to
5232a2f
Compare
|
🎉 A preview for this PR is available at: https://preview-developer.espressif.com/pr598/ |
FBEZ
left a comment
FBEZ
left a comment
There was a problem hiding this comment.
A few minor observations (not about the content).
If you agree with them, I'll change the text.
|
|
||
| --- | ||
|
|
||
| ## Get Started |
There was a problem hiding this comment.
I'd change get started with further reading because reading "get started" after conclusion makes me uncomfortable :D
Other options References, Resources etc.
| ## Get Started | |
| ## Further reading |
There was a problem hiding this comment.
Sure. Now going through it again yes, it looks odd.
| {{< /alert >}} | ||
|
|
||
|
|
||
| ## What’s New: Integrated RED‑DA Support in ESP‑ZeroCode |
There was a problem hiding this comment.
I would change the headings from title case to sentence case just to be in line with the style elsewhere.
| ## What’s New: Integrated RED‑DA Support in ESP‑ZeroCode | |
| ## What’s new: Integrated RED‑DA support in ESP‑ZeroCode |
| - Learn about the **RED‑DA Assessment Tool** (background and preparation): | ||
| <https://red-da-assessment-tool.security.espressif.com> | ||
|
|
||
| *Espressif Systems – enabling secure, compliant, and interoperable IoT innovation, from design to deployment.* |
There was a problem hiding this comment.
I'd remove this line, looks like too much marketing-y.
| *Espressif Systems – enabling secure, compliant, and interoperable IoT innovation, from design to deployment.* |
|
The check fail is due to an older article which has a link which is now broken (or not replying fast enough) and has nothing to do with this one. ./content/blog/reducing-costs-and-complexity-for-deploying-connected-devices-with-esp-hosted/index.md:*Thanks to *[*Amey Inamdar*](https://medium.com/u/96a9b11b7090?source=post_page-----63ff9511ddef--------------------------------)* for the review and feedback.*
./public/blog/reducing-costs-and-complexity-for-deploying-connected-devices-with-esp-hosted/index.html:<p><em>Thanks to <em><a href="https://medium.com/u/96a9b11b7090?source=post_page-----63ff9511ddef--------------------------------" target="_blank"><em>Amey Inamdar</em></a></em> for the review and feedback.</em></p>@f-hollow what do you suggest to do? |
| default=true | ||
| src="esp-zerocode-benefits.webp" | ||
| caption="[ESP-ZeroCode Benefits](./img/esp-zerocode-benefits.webp)" | ||
| >}} |
There was a problem hiding this comment.
The figure not being displayed on the preview!! Need to check!!
There was a problem hiding this comment.
Please update the figure shortcode like this:
{{< figure
default=true
src="./img/esp-zerocode-benefits.webp"
caption="ESP-ZeroCode Benefits"
>}}
| default=true | ||
| src="esp-zerocode-red-da-details.webp" | ||
| caption="[ESP-ZeroCode RED-DA Product Details](./img/esp-zerocode-red-da-details.webp)" | ||
| >}} |
There was a problem hiding this comment.
Same as above for the picture preview
There was a problem hiding this comment.
Please update the figure shortcode like this:
{{< figure
default=true
src="./img/esp-zerocode-red-da-details.webp"
caption="ESP-ZeroCode RED-DA Product Details"
>}}
We just ignore it. For the possible underlying reasons, see Unrelated links reported. Hope we can investigate this issue and come up with a fix soon. |
4 participants
Checklist
Before submitting a Pull Request, please ensure the following: