Skip to content

Commit 199e40e

Browse files
committed
ci(build): Not fail CI, when used IDF from master + cleaning
1 parent 823b514 commit 199e40e

File tree

9 files changed

+45
-63
lines changed

9 files changed

+45
-63
lines changed

.github/workflows/build-run-applications.yml

Lines changed: 37 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -34,52 +34,23 @@ jobs:
3434
idf_build_apps_ver: "2.10.1"
3535
strategy:
3636
matrix:
37+
idf_ver:
38+
- "latest"
39+
- "release-v6.0"
40+
- "release-v5.5"
41+
- "release-v5.4"
42+
- "release-v5.3"
43+
- "release-v5.2"
44+
- "release-v5.1"
45+
parallel_index: [1, 2, 3, 4, 5]
3746
include:
47+
# Default values for all versions
48+
- parallel_count: 5
49+
allow_fail: false
3850
- idf_ver: "latest"
39-
parallel_count: 5
40-
parallel_index: 1
41-
- idf_ver: "latest"
42-
parallel_count: 5
43-
parallel_index: 2
44-
- idf_ver: "latest"
45-
parallel_count: 5
46-
parallel_index: 3
47-
- idf_ver: "latest"
48-
parallel_count: 5
49-
parallel_index: 4
50-
- idf_ver: "latest"
51-
parallel_count: 5
52-
parallel_index: 5
53-
- idf_ver: "release-v5.1"
54-
parallel_count: 2
55-
parallel_index: 1
56-
- idf_ver: "release-v5.1"
57-
parallel_count: 2
58-
parallel_index: 2
59-
- idf_ver: "release-v5.2"
60-
parallel_count: 2
61-
parallel_index: 1
62-
- idf_ver: "release-v5.2"
63-
parallel_count: 2
64-
parallel_index: 2
65-
- idf_ver: "release-v5.3"
66-
parallel_count: 2
67-
parallel_index: 1
68-
- idf_ver: "release-v5.3"
69-
parallel_count: 2
70-
parallel_index: 2
71-
- idf_ver: "release-v5.4"
72-
parallel_count: 2
73-
parallel_index: 1
74-
- idf_ver: "release-v5.4"
75-
parallel_count: 2
76-
parallel_index: 2
77-
- idf_ver: "release-v5.5"
78-
parallel_count: 2
79-
parallel_index: 1
80-
- idf_ver: "release-v5.5"
81-
parallel_count: 2
82-
parallel_index: 2
51+
allow_fail: true # Do not fail CI, when fail "latest" build
52+
- idf_ver: "release-v6.0" # TODO: Remove thi section, when "release-v6.0" will be stable
53+
allow_fail: true # Do not fail CI, when fail "release-v6.0" build
8354
runs-on: ubuntu-latest
8455
container: espressif/idf:${{ matrix.idf_ver }}
8556
steps:
@@ -93,6 +64,8 @@ jobs:
9364
separator: ';' # idf-build-apps expects files seprated with semicolon
9465

9566
- name: Build ESP-BSP applications
67+
id: buildapps
68+
continue-on-error: ${{ github.event_name == 'pull_request' && matrix.allow_fail == true }}
9669
if: always()
9770
shell: bash
9871
env:
@@ -107,8 +80,26 @@ jobs:
10780
idf-build-apps find ${{env.ALL_CHANGED_FILES}}
10881
idf-build-apps build --parallel-count ${{ matrix.parallel_count }} --parallel-index ${{ matrix.parallel_index }} ${{env.ALL_CHANGED_FILES}} --collect-app-info build_info_${{ matrix.idf_ver }}_${{ matrix.parallel_index }}.json
10982
83+
# Warning, if failed with master
84+
- name: Warn if latest build failed
85+
if: ${{ github.event_name == 'pull_request' && steps.buildapps.outcome == 'failure' && matrix.allow_fail == true }}
86+
run: |
87+
echo "::warning::Build failed for idf_ver=${{ matrix.idf_ver }} (ignored because it's '${{ matrix.idf_ver }}')"
88+
echo "### ⚠️ Build failed for idf_ver=${{ matrix.idf_ver }}" >> $GITHUB_STEP_SUMMARY
89+
echo "This failure was ignored (continue-on-error enabled)." >> $GITHUB_STEP_SUMMARY
90+
91+
# Warning, if failed with master
92+
- name: Warn if latest build failed Comment PR
93+
if: ${{ github.event_name == 'pull_request' && steps.buildapps.outcome == 'failure' && matrix.allow_fail == true }}
94+
uses: thollander/actions-comment-pull-request@v3
95+
with:
96+
message: |
97+
### ⚠️ Build failed for idf_ver=${{ matrix.idf_ver }} index=${{ matrix.parallel_index }}
98+
This failure was ignored (continue-on-error enabled).
99+
See details: [View build logs](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}#step:${{ github.job }})
100+
110101
- uses: actions/upload-artifact@v4
111-
if: github.repository_owner == 'espressif' && needs.prepare.outputs.build_only == '0'
102+
if: github.repository_owner == 'espressif' # && needs.prepare.outputs.build_only == '0'
112103
with:
113104
name: app_binaries_${{ matrix.idf_ver }}_${{ matrix.parallel_index }}
114105
path: |
@@ -128,7 +119,7 @@ jobs:
128119
max-parallel: 5
129120
matrix:
130121
idf_ver:
131-
- "latest"
122+
- "release-v5.5"
132123
runner:
133124
- example: "test_example_display"
134125
- example: "test_example_lvgl_demos"

components/esp_lvgl_port/examples/rgb_lcd/main/main.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ static esp_err_t app_lvgl_init(void)
254254
return ESP_OK;
255255
}
256256

257+
#if 0
257258
static void _app_button_cb(lv_event_t *e)
258259
{
259260
lv_disp_rotation_t rotation = lv_disp_get_rotation(lvgl_disp);
@@ -265,7 +266,6 @@ static void _app_button_cb(lv_event_t *e)
265266
/* LCD HW rotation */
266267
lv_disp_set_rotation(lvgl_disp, rotation);
267268
}
268-
269269
static void app_main_display(void)
270270
{
271271
lv_obj_t *scr = lv_scr_act();
@@ -296,6 +296,7 @@ static void app_main_display(void)
296296
lv_obj_align(btn, LV_ALIGN_BOTTOM_MID, 0, -30);
297297
lv_obj_add_event_cb(btn, _app_button_cb, LV_EVENT_CLICKED, NULL);
298298
}
299+
#endif
299300

300301
void app_main(void)
301302
{
@@ -313,4 +314,5 @@ void app_main(void)
313314
//app_main_display();
314315
lv_demo_music();
315316
lvgl_port_unlock();
317+
316318
}

components/esp_lvgl_port/examples/rgb_lcd/sdkconfig.defaults

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ CONFIG_SPIRAM_SPEED_80M=y
1111
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
1212
CONFIG_ESP32S3_DATA_CACHE_LINE_64B=y
1313
CONFIG_FREERTOS_HZ=1000
14-
CONFIG_LV_MEM_CUSTOM=y
15-
CONFIG_LV_MEMCPY_MEMSET_STD=y
1614
#CONFIG_LV_ATTRIBUTE_FAST_MEM_USE_IRAM=y
1715
CONFIG_LV_FONT_MONTSERRAT_12=y
1816
CONFIG_LV_FONT_MONTSERRAT_16=y
@@ -22,10 +20,6 @@ CONFIG_LV_USE_DEMO_STRESS=y
2220
CONFIG_LV_USE_DEMO_MUSIC=y
2321
CONFIG_LV_DEMO_MUSIC_AUTO_PLAY=y
2422

25-
## LVGL8 ##
26-
CONFIG_LV_MEM_SIZE_KILOBYTES=48
27-
CONFIG_LV_USE_PERF_MONITOR=y
28-
2923
## LVGL9 ##
3024
CONFIG_LV_CONF_SKIP=y
3125

@@ -38,3 +32,8 @@ CONFIG_LV_USE_CLIB_STRING=y
3832
CONFIG_LV_USE_OBSERVER=y
3933
CONFIG_LV_USE_SYSMON=y
4034
CONFIG_LV_USE_PERF_MONITOR=y
35+
36+
## LVGL8 - uncomment, when using LVGL8 ##
37+
CONFIG_LV_MEM_SIZE_KILOBYTES=48
38+
# CONFIG_LV_MEM_CUSTOM=y
39+
# CONFIG_LV_MEMCPY_MEMSET_STD=y
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
CONFIG_IDF_TARGET="esp32s3"
22
CONFIG_ESPTOOLPY_FLASHMODE_QIO=y
33
CONFIG_ESPTOOLPY_FLASHSIZE_16MB=y
4-
CONFIG_LV_COLOR_16_SWAP=y
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
CONFIG_IDF_TARGET="esp32s3"
22
CONFIG_ESPTOOLPY_FLASHMODE_QIO=y
33
CONFIG_ESPTOOLPY_FLASHSIZE_16MB=y
4-
CONFIG_LV_COLOR_16_SWAP=y
54
CONFIG_FREERTOS_HZ=1000
65
CONFIG_ESP_TASK_WDT_EN=n
76
CONFIG_ESP_CONSOLE_USB_SERIAL_JTAG=y
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
21
CONFIG_ESP_TASK_WDT_EN=n
32
CONFIG_FREERTOS_HZ=1000
43
CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
21
CONFIG_ESP_TASK_WDT_EN=n
32
CONFIG_FREERTOS_HZ=1000
43
CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
21
CONFIG_ESP_TASK_WDT_EN=n
32
CONFIG_FREERTOS_HZ=1000
43
CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096

components/qma6100p/test_apps/sdkconfig.defaults

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
11
CONFIG_IDF_TARGET="esp32s3"
22
CONFIG_ESPTOOLPY_FLASHFREQ_80M=y
33
CONFIG_COMPILER_OPTIMIZATION_PERF=y
4-
CONFIG_SPIRAM=y
5-
CONFIG_SPIRAM_MODE_OCT=y
6-
CONFIG_SPIRAM_FETCH_INSTRUCTIONS=y
7-
CONFIG_SPIRAM_RODATA=y
8-
CONFIG_SPIRAM_SPEED_80M=y
94
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
105
CONFIG_ESP_TASK_WDT_EN=n
116
CONFIG_FREERTOS_HZ=1000

0 commit comments

Comments
 (0)