Skip to content

Commit be22e97

Browse files
committed
ci(build): Not fail CI, when used IDF from master + cleaning
1 parent 823b514 commit be22e97

File tree

6 files changed

+64
-30
lines changed

6 files changed

+64
-30
lines changed

.github/workflows/build-run-applications.yml

Lines changed: 56 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -29,57 +29,74 @@ concurrency:
2929

3030
jobs:
3131
build:
32+
continue-on-error: ${{ matrix.allow_fail == true }}
3233
env:
3334
component_manager_ver: "2.2.*"
3435
idf_build_apps_ver: "2.10.1"
3536
strategy:
37+
fail-fast: false
3638
matrix:
3739
include:
3840
- idf_ver: "latest"
39-
parallel_count: 5
41+
parallel_count: 3
4042
parallel_index: 1
43+
allow_fail: true
4144
- idf_ver: "latest"
42-
parallel_count: 5
45+
parallel_count: 3
4346
parallel_index: 2
47+
allow_fail: true
4448
- idf_ver: "latest"
45-
parallel_count: 5
49+
parallel_count: 3
4650
parallel_index: 3
47-
- idf_ver: "latest"
48-
parallel_count: 5
49-
parallel_index: 4
50-
- idf_ver: "latest"
51-
parallel_count: 5
52-
parallel_index: 5
53-
- idf_ver: "release-v5.1"
51+
allow_fail: true
52+
- idf_ver: "release-v6.0"
5453
parallel_count: 2
5554
parallel_index: 1
56-
- idf_ver: "release-v5.1"
55+
allow_fail: false
56+
- idf_ver: "release-v6.0"
5757
parallel_count: 2
5858
parallel_index: 2
59-
- idf_ver: "release-v5.2"
59+
allow_fail: false
60+
- idf_ver: "release-v5.5"
6061
parallel_count: 2
6162
parallel_index: 1
62-
- idf_ver: "release-v5.2"
63+
allow_fail: false
64+
- idf_ver: "release-v5.5"
65+
parallel_count: 2
66+
parallel_index: 2
67+
allow_fail: false
68+
- idf_ver: "release-v5.4"
69+
parallel_count: 2
70+
parallel_index: 1
71+
allow_fail: false
72+
- idf_ver: "release-v5.4"
6373
parallel_count: 2
6474
parallel_index: 2
75+
allow_fail: false
6576
- idf_ver: "release-v5.3"
6677
parallel_count: 2
6778
parallel_index: 1
79+
allow_fail: false
6880
- idf_ver: "release-v5.3"
6981
parallel_count: 2
7082
parallel_index: 2
71-
- idf_ver: "release-v5.4"
83+
allow_fail: false
84+
- idf_ver: "release-v5.2"
7285
parallel_count: 2
7386
parallel_index: 1
74-
- idf_ver: "release-v5.4"
87+
allow_fail: false
88+
- idf_ver: "release-v5.2"
7589
parallel_count: 2
7690
parallel_index: 2
77-
- idf_ver: "release-v5.5"
91+
allow_fail: false
92+
- idf_ver: "release-v5.1"
7893
parallel_count: 2
7994
parallel_index: 1
80-
- idf_ver: "release-v5.5"
95+
allow_fail: false
96+
- idf_ver: "release-v5.1"
8197
parallel_count: 2
8298
parallel_index: 2
99+
allow_fail: false
83100
runs-on: ubuntu-latest
84101
container: espressif/idf:${{ matrix.idf_ver }}
85102
steps:
@@ -93,19 +110,38 @@ jobs:
93110
separator: ';' # idf-build-apps expects files seprated with semicolon
94111

95112
- name: Build ESP-BSP applications
113+
continue-on-error: ${{ matrix.allow_fail == true }}
96114
if: always()
97115
shell: bash
98116
env:
99117
IDF_EXTRA_ACTIONS_PATH: "${{ github.workspace }}/examples"
100118
# When event not a pull-request, the action before must be skipped and the steps.changed-files.outputs.all_modified_files variable is not exists and must be removed
101-
ALL_CHANGED_FILES: ${{ (github.event_name != 'pull_request') && format(' ') || format('--modified-files=') }}${{ (github.event_name != 'pull_request') && format(' ') || steps.changed-files.outputs.all_modified_files }}
119+
# ALL_CHANGED_FILES: ${{ (github.event_name != 'pull_request') && format(' ') || format('--modified-files=') }}${{ (github.event_name != 'pull_request') && format(' ') || steps.changed-files.outputs.all_modified_files }}
120+
ALL_CHANGED_FILES:
102121
run: |
103122
. ${IDF_PATH}/export.sh
104123
pip install idf-component-manager==${{ env.component_manager_ver }} ruamel.yaml idf-build-apps==${{ env.idf_build_apps_ver }} --upgrade
105124
106125
echo "Files changed: "${{env.ALL_CHANGED_FILES}}
107126
idf-build-apps find ${{env.ALL_CHANGED_FILES}}
108-
idf-build-apps build --parallel-count ${{ matrix.parallel_count }} --parallel-index ${{ matrix.parallel_index }} ${{env.ALL_CHANGED_FILES}} --collect-app-info build_info_${{ matrix.idf_ver }}_${{ matrix.parallel_index }}.json
127+
idf-build-apps build --parallel-count ${{ matrix.parallel_count }} --parallel-index ${{ matrix.parallel_index }} ${{env.ALL_CHANGED_FILES}} --collect-app-info build_info_${{ matrix.idf_ver }}_${{ matrix.parallel_index }}.json || echo "BUILD_FAILED=true" >> $GITHUB_ENV
128+
129+
# Warning, if failed with master
130+
- name: Warn if latest build failed
131+
if: ${{ env.BUILD_FAILED == 'true' && matrix.allow_fail == true }}
132+
run: |
133+
echo "::warning::Build failed for idf_ver=${{ matrix.idf_ver }} (ignored because it's 'latest')"
134+
echo "### ⚠️ Build failed for idf_ver=${{ matrix.idf_ver }}" >> $GITHUB_STEP_SUMMARY
135+
echo "This failure was ignored (continue-on-error enabled)." >> $GITHUB_STEP_SUMMARY
136+
137+
# Warning, if failed with master
138+
- name: Warn if latest build failed Comment PR
139+
if: ${{ env.BUILD_FAILED == 'true' && matrix.allow_fail == true }}
140+
uses: thollander/actions-comment-pull-request@v3
141+
with:
142+
message: |
143+
### ⚠️ Build failed for idf_ver=${{ matrix.idf_ver }} index=${{ matrix.parallel_index }}
144+
This failure was ignored (continue-on-error enabled).
109145
110146
- uses: actions/upload-artifact@v4
111147
if: github.repository_owner == 'espressif' && needs.prepare.outputs.build_only == '0'
@@ -128,7 +164,7 @@ jobs:
128164
max-parallel: 5
129165
matrix:
130166
idf_ver:
131-
- "latest"
167+
- "release-v6.0"
132168
runner:
133169
- example: "test_example_display"
134170
- example: "test_example_lvgl_demos"

components/esp_lvgl_port/examples/rgb_lcd/main/main.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,7 @@ static esp_err_t app_lvgl_init(void)
254254
return ESP_OK;
255255
}
256256

257+
#if 0
257258
static void _app_button_cb(lv_event_t *e)
258259
{
259260
lv_disp_rotation_t rotation = lv_disp_get_rotation(lvgl_disp);
@@ -265,7 +266,6 @@ static void _app_button_cb(lv_event_t *e)
265266
/* LCD HW rotation */
266267
lv_disp_set_rotation(lvgl_disp, rotation);
267268
}
268-
269269
static void app_main_display(void)
270270
{
271271
lv_obj_t *scr = lv_scr_act();
@@ -296,6 +296,7 @@ static void app_main_display(void)
296296
lv_obj_align(btn, LV_ALIGN_BOTTOM_MID, 0, -30);
297297
lv_obj_add_event_cb(btn, _app_button_cb, LV_EVENT_CLICKED, NULL);
298298
}
299+
#endif
299300

300301
void app_main(void)
301302
{
@@ -313,4 +314,5 @@ void app_main(void)
313314
//app_main_display();
314315
lv_demo_music();
315316
lvgl_port_unlock();
317+
316318
}

components/esp_lvgl_port/examples/rgb_lcd/sdkconfig.defaults

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ CONFIG_SPIRAM_SPEED_80M=y
1111
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
1212
CONFIG_ESP32S3_DATA_CACHE_LINE_64B=y
1313
CONFIG_FREERTOS_HZ=1000
14-
CONFIG_LV_MEM_CUSTOM=y
15-
CONFIG_LV_MEMCPY_MEMSET_STD=y
1614
#CONFIG_LV_ATTRIBUTE_FAST_MEM_USE_IRAM=y
1715
CONFIG_LV_FONT_MONTSERRAT_12=y
1816
CONFIG_LV_FONT_MONTSERRAT_16=y
@@ -22,10 +20,6 @@ CONFIG_LV_USE_DEMO_STRESS=y
2220
CONFIG_LV_USE_DEMO_MUSIC=y
2321
CONFIG_LV_DEMO_MUSIC_AUTO_PLAY=y
2422

25-
## LVGL8 ##
26-
CONFIG_LV_MEM_SIZE_KILOBYTES=48
27-
CONFIG_LV_USE_PERF_MONITOR=y
28-
2923
## LVGL9 ##
3024
CONFIG_LV_CONF_SKIP=y
3125

@@ -38,3 +32,8 @@ CONFIG_LV_USE_CLIB_STRING=y
3832
CONFIG_LV_USE_OBSERVER=y
3933
CONFIG_LV_USE_SYSMON=y
4034
CONFIG_LV_USE_PERF_MONITOR=y
35+
36+
## LVGL8 - uncomment, when using LVGL8 ##
37+
CONFIG_LV_MEM_SIZE_KILOBYTES=48
38+
# CONFIG_LV_MEM_CUSTOM=y
39+
# CONFIG_LV_MEMCPY_MEMSET_STD=y
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
21
CONFIG_ESP_TASK_WDT_EN=n
32
CONFIG_FREERTOS_HZ=1000
43
CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
21
CONFIG_ESP_TASK_WDT_EN=n
32
CONFIG_FREERTOS_HZ=1000
43
CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_240=y
21
CONFIG_ESP_TASK_WDT_EN=n
32
CONFIG_FREERTOS_HZ=1000
43
CONFIG_FREERTOS_TIMER_TASK_STACK_DEPTH=4096

0 commit comments

Comments
 (0)