-
Notifications
You must be signed in to change notification settings - Fork 177
feat(io_expander): Added new IO expander PI4OE5V6408 #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 20. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Test Results28 tests 28 ✅ 1m 30s ⏱️ Results for commit 0246b10. ♻️ This comment has been updated with latest results. |
tore-espressif
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@espzav nice work.
I left 2 question about implementation and 1 suggestion about tests
components/io_expander/esp_io_expander_pi4ioe5v6408/test_apps/main/test_app_pi4ioe5v6408.c
Outdated
Show resolved
Hide resolved
components/io_expander/esp_io_expander_pi4ioe5v6408/test_apps/main/test_app_pi4ioe5v6408.c
Show resolved
Hide resolved
9d4725e to
0246b10
Compare
|
|
|
|
@tore-espressif Thank you for review. All comments are resolved. PTAL |
ESP-BSP Pull Request checklist
Change description