Skip to content

feat(p4): Added avoid-tear feature and audio-related code. (BSP-560) #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2024
Merged

feat(p4): Added avoid-tear feature and audio-related code. (BSP-560) #401

merged 1 commit into from
Oct 23, 2024

Conversation

@Horion0415
Copy link
Contributor

@Horion0415 Horion0415 commented Oct 5, 2024 •
edited by espzav
Loading

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

  • Added tear-proofing feature in the LVGL context
  • Added audio-related code
  • Optimized some configurations and initialization methods

@Horion0415 Horion0415 force-pushed the feat/add_p4_avoid_tear branch 4 times, most recently from 382c841 to 378ab88 Compare October 5, 2024 07:30
@github-actions github-actions bot changed the title feat(p4): Added avoid-tear feature and audio-related code. feat(p4): Added avoid-tear feature and audio-related code. (BSP-560) Oct 5, 2024
tore-espressif
tore-espressif approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Horion0415 thank you very much for the PR! I left few nitpicks/questions

@espzav PTAL and the esp_lvgl_port part :)

@Horion0415 Horion0415 mentioned this pull request Oct 11, 2024
Open
3 tasks
@tore-espressif tore-espressif mentioned this pull request Oct 11, 2024
Merged
@igrr
Copy link
Member

igrr commented Oct 11, 2024

@Horion0415 SD card changes have been merged in #405, please rebase on top of it. Sorry for the trouble!

igrr
igrr reviewed Oct 11, 2024
View reviewed changes
@Horion0415 Horion0415 force-pushed the feat/add_p4_avoid_tear branch 3 times, most recently from c0a0b73 to 90db0a0 Compare October 14, 2024 04:02
espzav
espzav reviewed Oct 14, 2024
View reviewed changes
@Horion0415 Horion0415 force-pushed the feat/add_p4_avoid_tear branch from 90db0a0 to 2fc3f8a Compare October 15, 2024 12:13
espzav
espzav reviewed Oct 17, 2024
View reviewed changes
@Horion0415 Horion0415 force-pushed the feat/add_p4_avoid_tear branch 5 times, most recently from c18c16f to 396a35d Compare October 23, 2024 03:37
@espzav espzav mentioned this pull request Oct 23, 2024
Closed
1 task
@espzav
Copy link
Collaborator

espzav commented Oct 23, 2024 •
edited
Loading

@Horion0415 Sorry for my mistake, I overlooked - there is missing update version of esp_lvgl_port + update changelog. Please, could you update it?

@Horion0415 Horion0415 force-pushed the feat/add_p4_avoid_tear branch from 396a35d to 417fddc Compare October 23, 2024 06:27
@Horion0415
Copy link
Contributor Author

Horion0415 commented Oct 23, 2024

Alright, that was my oversight. Considering the significant modifications to the esp_lvgl_port this time, along with the addition of some new features, I have bumped the minor version. I'm not sure if this is appropriate?

@espzav
Copy link
Collaborator

espzav commented Oct 23, 2024

Alright, that was my oversight. Considering the significant modifications to the esp_lvgl_port this time, along with the addition of some new features, I have bumped the minor version. I'm not sure if this is appropriate?

Thank you very much! It is ok, the major version is usually the big change (breaking change)

@espzav espzav force-pushed the feat/add_p4_avoid_tear branch from 417fddc to 44efecb Compare October 23, 2024 06:38
espzav
espzav approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@espzav espzav merged commit 29bebaf into espressif:master Oct 23, 2024
16 checks passed
@igrr
Copy link
Member

igrr commented Oct 31, 2024

@espzav seems that this PR has introduced a build warning:

/__w/idf-extra-components/idf-extra-components/thorvg/examples/thorvg-example/managed_components/espressif__esp32_p4_function_ev_board_noglib/esp32_p4_function_ev_board.c: In function 'bsp_audio_init':
/__w/idf-extra-components/idf-extra-components/thorvg/examples/thorvg-example/managed_components/espressif__esp32_p4_function_ev_board_noglib/esp32_p4_function_ev_board.c:184:15: error: unused variable 'ret' [-Werror=unused-variable]
  184 |     esp_err_t ret = ESP_FAIL;
      |               ^~~

https://github.com/espressif/idf-extra-components/actions/runs/11603657651/job/32311078844#step:5:30731

@tore-espressif
Copy link
Collaborator

tore-espressif commented Oct 31, 2024

Will fix soon, sorry for the inconvenience...

@tore-espressif
Copy link
Collaborator

tore-espressif commented Oct 31, 2024

Fixed here #427

@Horion0415
Copy link
Contributor Author

Horion0415 commented Nov 1, 2024

I am truly sorry for this oversight. (╥﹏╥)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igrr igrr igrr left review comments

@tore-espressif tore-espressif tore-espressif approved these changes

@espzav espzav espzav approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Horion0415 @igrr @espzav @tore-espressif