Skip to content

Conversation

@tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Oct 10, 2024

ESP-BSP Pull Request checklist

  • Version of modified component bumped
  • CI passing
  • Try on HW!!!

Change description

Update ICM42670 driver to I2C driver-NG

Related

@tore-espressif tore-espressif self-assigned this Oct 10, 2024
@tore-espressif tore-espressif changed the title Refactor/icm4267 i2c ng ICM4267: I2C Driver-NG Oct 10, 2024
@tore-espressif tore-espressif requested a review from espzav October 10, 2024 17:36
@tore-espressif tore-espressif changed the title ICM4267: I2C Driver-NG ICM42670: I2C Driver-NG Oct 10, 2024
@tore-espressif tore-espressif force-pushed the refactor/icm4267_i2c_ng branch from 37fc0ac to c983f4d Compare October 11, 2024 07:24
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tore-espressif Thank you for this PR. I tested it on ESP-BOX-3 and found some issues in test app.

@tore-espressif tore-espressif force-pushed the refactor/icm4267_i2c_ng branch 2 times, most recently from af75334 to ba303c0 Compare October 14, 2024 20:13
@tore-espressif tore-espressif force-pushed the refactor/icm4267_i2c_ng branch from ba303c0 to 8c75afa Compare October 16, 2024 05:56
@tore-espressif
Copy link
Collaborator Author

@espzav I did more local HW tests, all seems to work fine, PTAL!

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tore-espressif tore-espressif merged commit f580175 into master Oct 16, 2024
16 checks passed
@tore-espressif tore-espressif deleted the refactor/icm4267_i2c_ng branch October 16, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants