incorporating relevant changes from led_strip v3.0.0 (BSP-574)

[rishi9699]

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

• Version of modified component bumped
• CI passing

Change description

Recently a new version (v3.0.0) of led_strip was pushed. This changed the led_strip_config_t struct in the

led_strip/include/led_strip_types.h

file.

Please check the latest change of led_strip repository here

Closes #420

[CLAassistant]

All committers have signed the CLA.

[igrr]

cc @espzav @tore-espressif

I think we also need to add a version constraint on led_strip somewhere, or possibly have ifdefs for led_strip v2 and v3.

[suda-morris]

cc @espzav @tore-espressif

I think we also need to add a version constraint on led_strip somewhere, or possibly have ifdefs for led_strip v2 and v3.

We'd better to set a proper dependency in here

[igrr]

True, led_indicator component should also change the way the dependency is set.

However, since esp_bsp_generic also uses led_strip API directly, it should specify the dependency and not rely on the version set in led_indicator.

Besides, I think it's better to allow both versions of led_strip, if possible. If we force led_strip>=3, we have to make a new major release of the BSP component. If we force led_strip<3, users won't be able to use esp_bsp_generic with led_strip>=3.

The best option would have probably been to not make a breaking change and a major release in led_strip in the first place :)

[suda-morris]

Besides, I think it's better to allow both versions of led_strip, if possible.

Yes, we can. Just remove the configuration of led_pixel_format and color_component_format when initialize the led_strip, let the driver fall-back to choose the default one. The esp_bsp_generic can compile with led_strip version 2 and 3.

[suda-morris]

I take the liberty to fix the build errors that are introduced by led_strip v3. Now the bsp package can work with both led_strip v2 and led_strip v3. @igrr @espzav PTAL.

[Lzw655]

Hi @suda-morris, LGTM. Please also update the version of the esp32-c3-lcdkit BSP. I tested the LED functionality using the compatible development board, and everything works fine.

[suda-morris]

Hi @suda-morris, LGTM. Please also update the version of the esp32-c3-lcdkit BSP. I tested the LED functionality using the compatible development board, and everything works fine.

c3-lcdkit already has a contraint to the led_strip:

  led_strip:
    version: "^2"
    public: true

So this PR actually didn't do any bugfix for that BSP, it's just a refactor.