BSP optional I2C pull up (BSP-620) #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
adamkaliszan
force-pushed
the
BST_I2C_PULLUP
branch
3 times, most recently
from
ae27344 to
24fbae1
Compare
tore-espressif
force-pushed
the
BST_I2C_PULLUP
branch
from
24fbae1 to
eb275de
Compare
adamkaliszan
force-pushed
the
BST_I2C_PULLUP
branch
from
eb275de to
7c69ef1
Compare
2 tasks
espzav
approved these changes
Jan 23, 2025
Collaborator
espzav
left a comment
espzav
left a comment
There was a problem hiding this comment.
@adamkaliszan thank you for this change, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no option in KCONFIG to enable I2C pull up. This option is supported by ESP-IDF.
This option is extremely helpful for newbies.