-
Notifications
You must be signed in to change notification settings - Fork 177
fix(lvgl_port): Improved and fixed deinit function (remove semaphore) #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results28 tests 28 ✅ 1m 32s ⏱️ Results for commit b1c0156. ♻️ This comment has been updated with latest results. |
4805d0f to
ed24a46
Compare
|
@PetrESP @tore-espressif PTAL |
PetrESP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me this change makes sense and is cleaner. Great job.
Personally I would maybe separate the touch driver change to a separate commit because from this I don't know how it's connected to the LVGL task.
ed24a46 to
b1c0156
Compare
|
|
|
|
|
ESP-BSP Pull Request checklist
Change description