bsp(m5stack_tab5): New BSP for M5Stack Tab5 #678
Conversation
espzav
force-pushed
the
bsp/m5stack_tab5
branch
from
c57bf16 to
3bda0e7
Compare
espzav
force-pushed
the
bsp/m5stack_tab5
branch
2 times, most recently
from
c5a163b to
42d8e2b
Compare
Test Results28 tests 28 ✅ 1m 31s ⏱️ Results for commit 3c53958. ♻️ This comment has been updated with latest results. |
espzav
force-pushed
the
bsp/m5stack_tab5
branch
2 times, most recently
from
8eb26b4 to
bcb0cc5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
@PetrESP @tore-espressif PTAL |
espzav
force-pushed
the
bsp/m5stack_tab5
branch
2 times, most recently
from
36c9662 to
1aa4804
Compare
| esp_io_expander_new_i2c_pi4ioe5v6408(i2c_handle, BSP_IO_EXPANDER_ADDRESS_1, &io_expander1); | ||
|
|
||
| return io_expander; | ||
| } |
There was a problem hiding this comment.
Bug: IO expander initialization without error checking
The bsp_io_expander_init() function does not check the return values of the two esp_io_expander_new_i2c_pi4ioe5v6408() calls at lines 935-936. If either initialization fails, the corresponding handle remains uninitialized, potentially causing NULL pointer dereferences when these handles are subsequently used by bsp_feature_enable() and other functions that call bsp_io_expander_init() and then immediately use io_expander or io_expander1 without NULL validation.
espzav
force-pushed
the
bsp/m5stack_tab5
branch
from
1aa4804 to
3043521
Compare
PetrESP
left a comment
PetrESP
left a comment
There was a problem hiding this comment.
Thank you for the PR. I am still testing out examples but I have few comments which I would like to discuss.
| | define | [**BSP\_CAMERA\_DEVICE**](#define-bsp_camera_device) (ESP\_VIDEO\_MIPI\_CSI\_DEVICE\_NAME)<br> | | ||
| | define | [**BSP\_CAMERA\_EN**](#define-bsp_camera_en) (GPIO\_NUM\_12)<br> | | ||
| | define | [**BSP\_CAMERA\_GPIO\_XCLK**](#define-bsp_camera_gpio_xclk) (GPIO\_NUM\_11)<br> | | ||
| | define | [**BSP\_CAMERA\_ROTATION**](#define-bsp_camera_rotation) (0)<br> | |
There was a problem hiding this comment.
Personally I think that it would be nice and easier for review and for the future look up of these changes if you separated changes to the P4 EYE into a separate commit.
There was a problem hiding this comment.
I wanted to change example, which is related to all camera boards.
espzav
force-pushed
the
bsp/m5stack_tab5
branch
from
3043521 to
571a13a
Compare
espzav
force-pushed
the
bsp/m5stack_tab5
branch
from
571a13a to
3c53958
Compare
|
|
|
|
|
|
|
|
|
|
Checklist for new Board Support package or Component
urlfield definedOptional: Component contains unit testsOptional: BSP was added to Runner (pytest.ini, conftest.py, build-run-applications.yml)Change description
io_expanderesp-bsp/examples/display_audio_photo/main/app_disp_fs.c
Line 350 in 21c6cd0
Not working Camera - missing right camera sensor- used compatible sensor SC202CSNote
Introduces the
m5stack_tab5BSP (ESP32‑P4) with MIPI-DSI display, GT911 touch, ES8388/ES7210 audio, SD, USB host, and MIPI-CSI camera, plus CI/docs/examples integration and camera example improvements.bsp/m5stack_tab5(ESP32‑P4)ili9881c(720x1280), backlight PWM, LDO power sequencing.gt911init and LVGL integration.es8388(speaker) andes7210(mic).SC202CS; feature control via IO expander.API.md, README), Doxygen config.sdkconfig.bsp.m5stack_tab5for multiple examples; include board in examples matrix/build rules.display_camera_csi: add aspect‑fit scaling, rotation handling, buffer mgmt cleanup; header/API tidy.m5stack_tab5to upload workflows (incl.noglib) andbsp_ext.py.README.mdtables (supported boards and examples).m5stack_tab5in.pre-commit-config.yaml.BSP_CAMERA_ROTATIONmacros toesp32_p4_*BSP headers/API.SquareLine/boards/v9/m5stack_tab5).Written by Cursor Bugbot for commit 3c53958. This will update automatically on new commits. Configure here.