fix(ci): Fixed noglib generating #681
Merged
+23
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
Collaborator
Author
|
@tore-espressif @PetrESP PTAL |
|
Test Results28 tests 28 ✅ 1m 30s ⏱️ Results for commit 6a60ba2. |
tore-espressif
approved these changes
Nov 21, 2025
Collaborator
tore-espressif
left a comment
tore-espressif
left a comment
There was a problem hiding this comment.
Thanks for the fix!
PetrESP
approved these changes
Nov 21, 2025
Collaborator
PetrESP
left a comment
PetrESP
left a comment
There was a problem hiding this comment.
Looks good from my side 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-BSP Pull Request checklist
Change description
Note
Fixes noglib generator to edit manifest via
manager.manifest, bumps BSP versions, and refreshes benchmark data./.github/ci/bsp_noglib.pyto remove dependencies viamanager.manifest.dependenciesand examples viamanager.manifest.examplesinstead ofmanifest_tree.bsp/esp32_p4_eye/idf_component.ymlto"2.0.0~1".bsp/esp32_p4_function_ev_board/idf_component.ymlto"5.1.0~1".bsp/esp32_p4_function_ev_board/README.md.Written by Cursor Bugbot for commit 6a60ba2. This will update automatically on new commits. Configure here.