-
Notifications
You must be signed in to change notification settings - Fork 0
fix: sending error responses (align with esptool) #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello jedi7, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
|
@Dzarda7 can you please look? |
|
@jedi7 can we just have uint16_t for the error and remove the esp_response? |
|
@Dzarda7 I wanted to do it that way, but not sure if this approach will be ok also for success responses. We can discuss that. |
|
I believe so, we can use just 0 for success right? |
2cf53cc to
0f45388
Compare
|
@Dzarda7 updated ;-) |
Dzarda7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you were against using typedefs here, but no issue. LGTM, thanks for the fix.
that was somebody else :) |
Description
Make the sending of error responses to be compatible with the esptool.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: