Skip to content

Conversation

@jedi7
Copy link
Collaborator

@jedi7 jedi7 commented Nov 26, 2025

Description

Make the sending of error responses to be compatible with the esptool.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@jedi7 jedi7 requested a review from Dzarda7 November 26, 2025 14:12
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello jedi7, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 0f45388

@jedi7
Copy link
Collaborator Author

jedi7 commented Nov 27, 2025

@Dzarda7 can you please look?

@Dzarda7
Copy link
Collaborator

Dzarda7 commented Nov 27, 2025

@jedi7 can we just have uint16_t for the error and remove the esp_response?

@jedi7
Copy link
Collaborator Author

jedi7 commented Nov 27, 2025

@Dzarda7 I wanted to do it that way, but not sure if this approach will be ok also for success responses. We can discuss that.

@Dzarda7
Copy link
Collaborator

Dzarda7 commented Nov 27, 2025

I believe so, we can use just 0 for success right?

@jedi7 jedi7 force-pushed the fix/error_responses branch from 2cf53cc to 0f45388 Compare November 27, 2025 14:56
@jedi7
Copy link
Collaborator Author

jedi7 commented Nov 27, 2025

@Dzarda7 updated ;-)

Copy link
Collaborator

@Dzarda7 Dzarda7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you were against using typedefs here, but no issue. LGTM, thanks for the fix.

@Dzarda7 Dzarda7 requested a review from dobairoland November 28, 2025 08:09
@jedi7
Copy link
Collaborator Author

jedi7 commented Nov 28, 2025

I thought you were against using typedefs here, but no issue. LGTM, thanks for the fix.

that was somebody else :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants