-
Notifications
You must be signed in to change notification settings - Fork 14
feat: Improved addr2line output formatting (IDFGH-15432) #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi nebkat, thank you for your another contribution to If the change is approved and passes the tests and human review, it will appear in this public Github repository after merge. 🔁 You can re-run automatic PR checks by retrying the DangerJS action |
|
Overall, this looks like a nice feature. Thank you for contributing. The pre-commit check is failing. Can you please fix this? |
aa752ff to
1197c86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the addr2line output formatting by adding color-coded output for enhanced readability. Key changes include:
- Updating the logger module to import additional color printing helpers.
- Replacing a single-address decoder call with a multi-address decoding approach.
- Iteratively printing formatted output for each decoded address entry, including inlined function names.
|
Hi @nebkat, I have one more request. When I ran the PR through our internal process, I realized that there is one test failing: https://github.com/espressif/esp-idf-monitor/blob/master/test/test_apps/monitor_addr_lookup/pytest_monitor_addr_lookup.py |
|
Oh, I am sorry for the confusion. I misread the log. The issue is actually the coloring between the "app_main" and "at". If you are unable to run this test, I can create a fix for you in a separate commit. |

Description
Adds colors to addr2line output:
Related
Requires espressif/esp-idf-panic-decoder#2
Testing
Tested locally with a variety of inputs.
Checklist
Before submitting a Pull Request, please ensure the following: