tx_ring_buf not checked for successful allocation

addowhite · web-flow · commit 1297790591d7 · 2025-11-28T17:48:28.000Z
diff --git a/components/esp_driver_usb_serial_jtag/src/usb_serial_jtag.c b/components/esp_driver_usb_serial_jtag/src/usb_serial_jtag.c
@@ -183,7 +183,7 @@ esp_err_t usb_serial_jtag_driver_install(usb_serial_jtag_driver_config_t *usb_se
     }
 
     p_usb_serial_jtag_obj->tx_ring_buf = xRingbufferCreate(usb_serial_jtag_config->tx_buffer_size, RINGBUF_TYPE_BYTEBUF);
-    if (p_usb_serial_jtag_obj->rx_ring_buf == NULL) {
+    if (p_usb_serial_jtag_obj->tx_ring_buf == NULL) {
         ESP_LOGE(USB_SERIAL_JTAG_TAG, "ringbuffer create error");
         err = ESP_ERR_NO_MEM;
         goto _exit;

Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ esp_err_t usb_serial_jtag_driver_install(usb_serial_jtag_driver_config_t *usb_se`
`183`	`183`	`}`
`184`	`184`
`185`	`185`	`p_usb_serial_jtag_obj->tx_ring_buf = xRingbufferCreate(usb_serial_jtag_config->tx_buffer_size, RINGBUF_TYPE_BYTEBUF);`
`186`		`- if (p_usb_serial_jtag_obj->rx_ring_buf == NULL) {`
	`186`	`+ if (p_usb_serial_jtag_obj->tx_ring_buf == NULL) {`
`187`	`187`	`ESP_LOGE(USB_SERIAL_JTAG_TAG, "ringbuffer create error");`
`188`	`188`	`err = ESP_ERR_NO_MEM;`
`189`	`189`	`goto _exit;`