Fixes compilation with -save-temps flag (IDFGH-12615)#13613
Conversation
👋 Hello denizzzka, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
|
@denizzzka Thanks for the PR, I think we can accept both changes in one branch (i.e. this PR). Could you please update the commit messages as suggested above by the checker, and click through the CLA? |
fa5a517 to
209f2cb
Compare
209f2cb to
1a38852
Compare
e6dabd7 to
4183043
Compare
|
Please pay attention to this PR |
|
(still relevant) |
|
Bump |
|
sha=41830433f4dc338b29ba1f97c5907bd805a271d8 |
|
Merging is blocked I don't understand what's going with this PR :-( |
4183043 to
50f947e
Compare
|
I don't understand. Why does the CI care about my local commit hooks?! This tiny PR is already two years old, lol |
c87067e to
50f947e
Compare
This damn machine is lying! Okay, just tell me if you need this or not. Maybe I'm wasting my time. I hate your CI system. |
Project's root
CMakeLists.txt:If try to compile with
-save-tempsand with:it causes error:
$ idf.py build lib
[...]
components/spiffs/spiffs/src/spiffs_nucleus.c: In function 'spiffs_populate_ix_map_v':
components/spiffs/spiffs/src/spiffs_nucleus.c:682:348: error: self-comparison always evaluates to false [-Werror=tautological-compare]
This PR fixes compilation for such case
Depends from #13612
Note
Low Risk
CMake-only compile-flag wiring; no SPIFFS runtime or API behavior changes.
Overview
Fixes SPIFFS failing to compile when the project adds
-save-tempstoCMAKE_C_FLAGSand GCC 12/13 warning disables are not enabled globally (e.g.spiffs_populate_ix_map_vtripping-Werror=tautological-compare).The component
CMakeLists.txtnow prepends${CMAKE_CURRENT_LIST_DIR}/to upstream SPIFFS sources beforeset_source_files_properties, so per-file flags like-Wno-formatapply reliably with temp-file builds. It drops the old GNU-only-Wno-stringop-truncationblock onspiffs_nucleus.cand instead appends-Wno-tautological-compareto that file’s existing compile flags (keeping-Wno-format).Reviewed by Cursor Bugbot for commit 50f947e. Bugbot is set up for automated code reviews on this repo. Configure here.