Update project.cmake (requires cmake >= 3.30) (IDFGH-16578)

[franz-ms-muc]

Description

enable Syntax:
target_link_libraries(forte PUBLIC $<LINK_LIBRARY:WHOLE_ARCHIVE,forte-iec61131-3>)

and similar.

Related

#17694
#14275

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Warnings

⚠️

Some issues found for the commit messages in this PR: the commit message "Update project.cmake": summary looks empty type/action looks empty Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello franz-ms-muc, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against e5917ab

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

[fhrbata]

I'm not sure we will be able to integrate this functionality when currently esp-idf minimum required cmake version is 3.22 and this feature was added in cmake 3.30

[franz-ms-muc]

it seems i found another Solution:
(honestly the "old" solution)
but it prevents a "dirty" Flag on esp-idf Version.

# define the libs
add_prebuilt_library(....

target_link_libraries(${COMPONENT_LIB} INTERFACE
-Wl,--whole-archive
  lib1
  lib2
  lib3
-Wl,--no-whole-archive
)

[fhrbata]

Hello @franz-ms-muc ,

I haven't tried it, but I think you might get into the same deduplication problem if more components use this approach. Meaning grouping multiple libs inside the --whole-archive.

I've been thinking a little bit more about the possibility of enabling the WHOLE_ARCHIVE feature, even though esp-idf still requires a minimum of cmake 3.22. If esp-idf itself does not use this feature, we could potentially make it available to projects using newer versions of cmake by adding it conditionally based on the cmake version. Something like(not tested):

if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.24")
   if("${IDF_TARGET}" STREQUAL "linux" AND CMAKE_HOST_SYSTEM_NAME STREQUAL "Darwin")
      set(CMAKE_LINK_LIBRARY_USING_WHOLE_ARCHIVE "LINKER:-force_load"
                                                 "<LINK_ITEM>")
   else()
      set(CMAKE_LINK_LIBRARY_USING_WHOLE_ARCHIVE "LINKER:--whole-archive"
                                                 "<LINK_ITEM>"
                                                 "LINKER:--no-whole-archive")
   endif()
   set(CMAKE_LINK_LIBRARY_USING_WHOLE_ARCHIVE_SUPPORTED TRUE)
   set(CMAKE_LINK_LIBRARY_WHOLE_ARCHIVE_ATTRIBUTES LIBRARY_TYPE=STATIC DEDUPLICATION=YES OVERRIDE=DEFAULT)
endif()

Thank you.