Skip to content

Conversation

@augustozanellato
Copy link

@augustozanellato augustozanellato commented Oct 29, 2025

Description

spiffs_res_to_errno maps SPIFFS_ERR_END_OF_OBJECT to EIO which breaks the common contract where errno should be 0 if readdir iterated through all the entries in a directory.

The fix is explicitly checking for SPIFFS_ERR_END_OF_OBJECT and in that case set errno to 0.

Related

The issue was discovered because a c++ std::filesystem::directory_iterator on a spiffs vfs path threw an std::filesystem::filesystem_error with the following message filesystem error: directory iterator cannot advance: I/O error

Testing

std::filesystem::directory_iterator on a spiffs vfs path now actually works without throwing exceptions


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Oct 29, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello augustozanellato, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 0116449

@github-actions github-actions bot changed the title fix(storage/spiffs): fix readdir setting errno on directory end fix(storage/spiffs): fix readdir setting errno on directory end (IDFGH-16698) Oct 29, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Oct 29, 2025
spiffs_res_to_errno maps `SPIFFS_ERR_END_OF_OBJECT` to EIO which breaks the common contract where
errno should be 0 if readdir iterated through all the entries in a directory.

The fix is explicitly checking for `SPIFFS_ERR_END_OF_OBJECT` and in that case set errno to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants