Skip to content

Conversation

@KaeLL
Copy link
Contributor

@KaeLL KaeLL commented Nov 9, 2025

Description

Bump esp_log v2 max argc. The abstract reasoning for it is that there's no completely objective way of determining a cap on how many arguments the logging functions should take, hence the ad-hoc approach. The concrete reasoning is so that I can migrate the main project I'm working on to log v2, which log elements of a couple of configuration structs.


Note

Extends ESP_LOG_INIT_ARG_TYPE_* macros from 48 to 60 to support up to 60 logging arguments.

  • Logging (binary args typing):
    • Extend ESP_LOG_INIT_ARG_TYPE_* definitions from ..._48 to ..._60, increasing supported logging arguments to 60.

Written by Cursor Bugbot for commit 3a9c352. This will update automatically on new commits. Configure here.

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello KaeLL, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 3a9c352

@github-actions github-actions bot changed the title Bump up log_v2's max arg count Bump up log_v2's max arg count (IDFGH-16764) Nov 9, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 9, 2025
@meetpatelvgec
Copy link
Collaborator

Hi @KaeLL
Thanks for raising this pull request to extend maximum argument count in esp-idf log_v2. The changes look good to me, and should be ok to merge.
I just wanted to check, if an arg count of 60 is sufficient for your project, or you might need more in future? Just trying to ensure that we keep some extra margin, so we don't need to update the arg count too frequently in future.

@KaeLL
Copy link
Contributor Author

KaeLL commented Nov 10, 2025

Hi @meetpatelvgec
A count of 51 was enough, but I bumped it up to 60 to account for that possibility. But it shouldn't be a surprise that, in practice, a fixed argc count means bumping that number up until it's high enough people stop noticing it (or memory consumption becomes a concern).

@meetpatelvgec
Copy link
Collaborator

sha=3a9c3524ae07e65aa0a915eb252bfc24487d26d3

@ESP-Marius ESP-Marius added the PR-Sync-Merge Pull request sync as merge commit label Nov 11, 2025
@ESP-Marius
Copy link
Collaborator

sha=3a9c3524ae07e65aa0a915eb252bfc24487d26d3

@ESP-Marius ESP-Marius added PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Merge Pull request sync as merge commit labels Nov 11, 2025
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new labels Nov 12, 2025
@espressif-bot espressif-bot merged commit b11ce34 into espressif:master Nov 14, 2025
9 of 10 checks passed
@espressif-bot espressif-bot added Resolution: Done Issue is done internally and removed Resolution: NA Issue resolution is unavailable labels Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants