Skip to content

Conversation

@KinhoLeung
Copy link

@KinhoLeung KinhoLeung commented Nov 24, 2025

Description
Set bytes_read to len in usb_uac_device_input_cb() after a successful esp_codec_dev_read().
This ensures the UAC stack receives the correct number of bytes and no longer interprets the callback as producing zero-length audio data.
image
Related
N/A (found while testing the USB UAC device input callback).
Testing
Built the USB UAC example.
Ran on an ESP32-S4 board and verified that audio input is correctly received by the host (no more zero-length data reported).


Note

Set bytes_read = len in usb_uac_device_input_cb so the UAC stack receives full-length audio data instead of zero-length.

Written by Cursor Bugbot for commit 05d11f8. This will update automatically on new commits. Configure here.

…ead in usb_uac_device_input_cb(), so the host correctly detects received audio data instead of seeing zero bytes.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix:Report the full buffer length to the UAC stack by setting bytes_read in usb_uac_device_input_cb(), so the host correctly detects received audio data instead of seeing zero bytes.":
    • summary should not end with a period (full stop)
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello KinhoLeung, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 05d11f8

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

return ESP_FAIL;
}

/* Report full-length data for UAC */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: bytes_read not set on error path

When esp_codec_dev_read fails, the function returns early without setting *bytes_read. This leaves the output parameter uninitialized or containing stale data, potentially causing the caller to misinterpret how many bytes were actually read. The error path needs to set *bytes_read = 0 before returning to indicate no data was successfully read.

Fix in Cursor Fix in Web

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 24, 2025
@github-actions github-actions bot changed the title fix:Report the full buffer length to the UAC stack by setting bytes_r… fix:Report the full buffer length to the UAC stack by setting bytes_r… (IDFGH-16855) Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Opened Issue is new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants