Skip to content

fix:Report the full buffer length to the UAC stack by setting bytes_r… (IDFGH-16855) #17926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −0
Open

fix:Report the full buffer length to the UAC stack by setting bytes_r… (IDFGH-16855) #17926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions examples/peripherals/i2s/i2s_advance/i2s_usb/main/i2s_usb_example_main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,11 @@ static esp_err_t usb_uac_device_input_cb(uint8_t *buf, size_t len, size_t *bytes
return ESP_FAIL;
}

/* Report full-length data for UAC */
Copy link

@cursor cursor bot Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: bytes_read not set on error path

When esp_codec_dev_read fails, the function returns early without setting *bytes_read. This leaves the output parameter uninitialized or containing stale data, potentially causing the caller to misinterpret how many bytes were actually read. The error path needs to set *bytes_read = 0 before returning to indicate no data was successfully read.

Fix in Cursor Fix in Web

if (bytes_read) {
*bytes_read = len;
}

return ESP_OK;
}

Expand Down