refactor(rtcio): remove duplicated macros in rtc_io_hal.h (IDFGH-16862)
#17933
+1
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the redundant, duplicated definitions of the following macros from
components/hal/include/hal/rtc_io_hal.h.rtcio_hal_get_levelrtcio_hal_set_levelI found that these two macros were defined twice (identically) within the same
#ifblock.This change removes the unnecessary definition for each macro.
The compiled output and behavior of the code remain unchanged.
Related
Testing
I have tested
rtc_gpio_set_levelandrtc_gpio_get_levelon ESP32-DevKitC.Checklist
Before submitting a Pull Request, please ensure the following:
Note
Remove duplicate
rtcio_hal_set_level/rtcio_hal_get_levelmacros and update SPDX year to 2025.components/hal/include/hal/rtc_io_hal.h):rtcio_hal_set_levelandrtcio_hal_get_level, retaining a single source of truth.2015-2025.Written by Cursor Bugbot for commit 10be743. This will update automatically on new commits. Configure here.