Skip to content

fix(usb_serial_jtag_driver): tx_ring_buf not checked for successful allocation (IDFGH-16876) #17945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(usb_serial_jtag_driver): tx_ring_buf not checked for successful allocation (IDFGH-16876) #17945

wants to merge 1 commit into from

Conversation

@addowhite
Copy link

@addowhite addowhite commented Nov 28, 2025 •
edited by cursor bot
Loading

The NULL check for rx_ring_buf looks to have been copied+pasted for tx_ring_buf but the name was not updated in both places.

This means if the tx_ring_buf allocation fails, an error is not returned.

Note

Corrects the NULL check to validate tx_ring_buf allocation (instead of rx_ring_buf) and properly error on failure in usb_serial_jtag_driver_install.

Written by Cursor Bugbot for commit 1297790. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 28, 2025 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "tx_ring_buf not checked for successful allocation":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello addowhite, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 1297790

@github-actions github-actions bot changed the title tx_ring_buf not checked for successful allocation in usb_serial_jtag_driver tx_ring_buf not checked for successful allocation in usb_serial_jtag_driver (IDFGH-16876) Nov 28, 2025
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 28, 2025
@addowhite addowhite changed the title tx_ring_buf not checked for successful allocation in usb_serial_jtag_driver (IDFGH-16876) fix(usb_serial_jtag_driver): tx_ring_buf not checked for successful allocation (IDFGH-16876) Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Opened Issue is new

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@addowhite @CLAassistant @espressif-bot