-
Notifications
You must be signed in to change notification settings - Fork 925
feat(lightbulb_driver): Update driver dependency (AEGHB-1224) #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello Vorrad, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
| @@ -1,4 +1,4 @@ | |||
| version: "1.10.1" | |||
| version: "1.10.2" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should increase the minor version, since the dependency change could lead to a build error if the user previously relies on the whole "driver" component implicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change made
988bb92 to
4d3dd25
Compare
|
Hi, please, is there a plan make similar changes for |
leeebo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vorrad LGTM! Thanks
|
sha=4d3dd251a1b13f27b4febc84d1acd297c2a6372a |
|
The changes already merged 1f29424 |
Description
Update the dependency from
driverto latest new driver components, to avoid compile mistakes in new IDF versions.Checklist
Before submitting a Pull Request, please ensure the following: