cam sensor component not compatible with idf5.5+ (AEGHB-1248)

[chegewara]

Checklist

• Checked the issue tracker for similar issues to ensure this is not a duplicate
• Read the documentation to confirm the issue is not addressed there and your configuration is set correctly
• Tested with the latest version to ensure the issue hasn't been fixed

How often does this bug occurs?

always

Expected behavior

To build with esp-idf 5.5.0+, or at least to pass CI.

Actual behavior (suspected bug)

This is code where it fails to build (maybe more code too)
https://github.com/espressif/esp-video-components/blob/master/esp_cam_sensor/src/driver_spi/spi_slave.c#L61-L77

Error logs or terminal output

Steps to reproduce the behavior

idf.py add-dependency "espressif/esp_video^1.2.0"

build

Project release version

esp-video 1.2.0+

System architecture

Intel/AMD 64-bit (modern PC, older Mac)

Operating system

Linux

Operating system version

ubuntu

Shell

Bash

Additional context

No response

[chegewara]

https://github.com/espressif/esp-video-components/blob/master/esp_video/src/data_reprocessing/esp32p4/esp_video_swap_byte.c#L93

bitscrambler_disable - does not exist

https://github.com/espressif/esp-video-components/blob/master/esp_video/src/data_reprocessing/esp32p4/esp_video_swap_byte.c#L41

bitscrambler_enable - does not exist

[donghengqaz]

Hi @chegewara , we have CI services to do compilation checking internally, but the CI services only use the newer commit in the release branches of esp-idf, so could you supply your esp-idf commit ID?

[chegewara]

commit 0f0068fff3ab159f082133aadfa9baf4fc0c7b8d (HEAD -> master, origin/master, origin/HEAD)

I believe that bug reported in OP is not idf version dependent.
This code is disabling definition of spi_bus_fsm_t based on idf version:

#if ESP_IDF_VERSION < ESP_IDF_VERSION_VAL(5, 5, 0)
// Status of a spi bus
typedef enum {
    SPI_BUS_FSM_DISABLED,               ///< Bus is disabled, clock and power is allowed to be closed.
    SPI_BUS_FSM_ENABLED,                ///< Bus is ready to be used
} spi_bus_fsm_t;

__attribute__((always_inline))
static inline void gpio_ll_set_input_signal_from(gpio_dev_t *hw, uint32_t signal_idx, bool from_gpio_matrix)
{
    hw->func_in_sel_cfg[signal_idx].sig_in_sel = from_gpio_matrix;
}
#endif

and yhis code is using it in all versions _Atomic spi_bus_fsm_t fsm;, so there is no way it could pass CI.

Thanks

[donghengqaz]

Hi @chegewara , I check your commit ID, this is a very older version between v5.4 and v5.5, you can the v5.5 was released in Jul 21. Actually the code management solution only can manage the code after some released tag, but can't manage the code before the released tag, especially some older commit ID.