Preserve repeated-start SCCB reads with fallback (#847)

* Revert "fix: fix addr8v8 read err in sccb_ng (#828)"

This reverts commit fafc200.

* fix: preserve repeated-start SCCB reads with fallback

Author: RubenKelevra

driver/sccb-ng.c

@@ -227,23 +227,41 @@ uint8_t SCCB_Read(uint8_t slv_addr, uint8_t reg)
 {
     i2c_master_dev_handle_t dev_handle = *(get_handle_from_address(slv_addr));
 
-    uint8_t tx_buffer[1];
-    uint8_t rx_buffer[1] = {0};
+    uint8_t tx_buffer[1] = { reg };
+    uint8_t rx_buffer[1] = { 0 };
 
-    tx_buffer[0] = reg;
+    esp_err_t ret = i2c_master_transmit_receive(dev_handle, tx_buffer, sizeof(tx_buffer),
+                                                rx_buffer, sizeof(rx_buffer), TIMEOUT_MS);
+    if (ret == ESP_OK)
+    {
+        return rx_buffer[0];
+    }
 
-    esp_err_t ret = i2c_master_transmit(dev_handle, tx_buffer, 1, TIMEOUT_MS);
+    /*
+     * Most SCCB sensors expect an 8-bit register read to use a repeated-start
+     * write/read transaction. Some devices reject that sequence with the new
+     * IDF I2C master driver, so only fall back to a stop/start read after the
+     * repeated-start transaction fails.
+     */
+    ESP_LOGD(TAG, "SCCB_Read repeated-start failed addr:0x%02x, reg:0x%02x, ret:%d; retrying",
+             slv_addr, reg, ret);
 
-    if (ret != ESP_OK) {
-        ESP_LOGE(TAG, "SCCB_Read addr phase failed addr:0x%02x, reg:0x%02x, ret:%d", slv_addr, reg, ret);
+    ret = i2c_master_transmit(dev_handle, tx_buffer, sizeof(tx_buffer), TIMEOUT_MS);
+    if (ret != ESP_OK)
+    {
+        ESP_LOGE(TAG, "SCCB_Read addr phase failed addr:0x%02x, reg:0x%02x, ret:%d",
+                 slv_addr, reg, ret);
         return 0;
     }
 
-    ret = i2c_master_receive(dev_handle, rx_buffer, 1, TIMEOUT_MS);
-    if (ret != ESP_OK) {
-        ESP_LOGE(TAG, "SCCB_Read Failed addr:0x%02x, reg:0x%02x, ret:%d", slv_addr, reg, ret);
+    ret = i2c_master_receive(dev_handle, rx_buffer, sizeof(rx_buffer), TIMEOUT_MS);
+    if (ret != ESP_OK)
+    {
+        ESP_LOGE(TAG, "SCCB_Read data phase failed addr:0x%02x, reg:0x%02x, ret:%d",
+                 slv_addr, reg, ret);
+        return 0;
     }
-    ESP_LOGD(TAG, "read OK");
+
     return rx_buffer[0];
 }