Skip to content

Commit 02444a7

Browse files
committed
rm packet from read arg
1 parent edc96c8 commit 02444a7

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

src/transport/ISerialTransport.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export interface ISerialTransport {
4343
* @param {Uint8Array} packet Unsigned 8 bit array from the device read stream.
4444
* @returns {Promise<Uint8Array>} 8 bit unsigned data array read from device.
4545
*/
46-
read(timeout?: number, minData?: number, packet?: Uint8Array): Promise<Uint8Array>;
46+
read(timeout?: number, minData?: number): Promise<Uint8Array>;
4747

4848
/**
4949
* Send the RequestToSend (RTS) signal to given state

src/transport/WebSerialTransport.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class WebSerialTransport implements ISerialTransport {
9898
* @param {Uint8Array} packet Unsigned 8 bit array from the device read stream.
9999
* @returns {Promise<Uint8Array>} 8 bit unsigned data array read from device.
100100
*/
101-
async read(timeout: number = 0, minData: number = 0, packet?: Uint8Array): Promise<Uint8Array> {
101+
async read(timeout: number = 0, minData: number = 0): Promise<Uint8Array> {
102102
if (this.leftOver.length != 0) {
103103
const p = this.leftOver;
104104
this.leftOver = new Uint8Array(0);
@@ -109,9 +109,7 @@ export class WebSerialTransport implements ISerialTransport {
109109
}
110110
this.reader = this.device.readable.getReader();
111111
let t;
112-
if (!packet) {
113-
packet = this.leftOver;
114-
}
112+
let packet = this.leftOver;
115113
try {
116114
if (timeout > 0) {
117115
t = setTimeout(() => {

src/utils/slip.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ export class Slip {
119119
packet = this.transport.leftOver;
120120
this.transport.leftOver = new Uint8Array(0);
121121
}
122-
packet = await this.transport.read(timeout, minData, packet);
122+
packet = await this.transport.read(timeout, minData);
123123

124124
if (this.tracer) {
125125
this.tracer.trace("Read SLIP bytes");

0 commit comments

Comments
 (0)