-
Notifications
You must be signed in to change notification settings - Fork 1.5k
rich-click 1.9 fix (ESPTOOL-1180) #1121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hello dwreeves, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
peterdragun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwreeves Thank you for the fix. This is much appreciated. Unfortunately, we cannot accept the PR, as we are following the conventional commits and have a bit more complicated release process (we use commitizen to automatically generate the Changelog based on the commits).
If you would like to fix the commit and take the credit, please update the commit message to something like: "fix(espefuse): Update CLI to support rich-click 1.9.0" and remove the changelog entry.
If not I will take over, this is already quite valuable insight for us anyway.
| commands.add_cli_commands(self) | ||
| elif len(used_cmds) == 0: | ||
| self.get_help(ctx) | ||
| print(self.get_help(ctx)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a custom logger class, that would be more suitable in this case (or even click.echo would work better)
| print(self.get_help(ctx)) | |
| log.print(self.get_help(ctx)) |
|
@peterdragun I'll close then and let you take it over, as I don't really care to take credit. I have a packed schedule today. Thank you! |
Resolves regression in rich-click 1.9.0 ewels/rich-click#253
This change fixes the following bug(s):
I have tested this change with the following hardware & software combinations:
NO TESTING
I have run the esptool automated integration tests with this change and the above hardware:
NO TESTING