Skip to content

rich-click 1.9 fix (ESPTOOL-1180) #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+6 −2
Closed

rich-click 1.9 fix (ESPTOOL-1180) #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd9241c
fix espefuse CLI for rich-click 1.9.0
dreeves-battery Sep 15, 2025
fbdbef1
update CHANGELOG
dreeves-battery Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
</div>
<hr>

## v5.0.3 (2025-09-)

- Fix bug with rich-click 1.9 compatibility *(Daniel Reeves - bd9241c)*

## v5.0.2 (2025-07-30)

### 🐛 Bug Fixes
Expand Down
2 changes: 1 addition & 1 deletion espefuse/cli_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ def parse_args(self, ctx: click.Context, args: list[str]):
commands = init_commands(port=None, chip=ctx.obj["chip"], skip_connect=True)
commands.add_cli_commands(self)
elif len(used_cmds) == 0:
self.get_help(ctx)
print(self.get_help(ctx))
Copy link
Collaborator

@peterdragun peterdragun Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a custom logger class, that would be more suitable in this case (or even click.echo would work better)

Suggested change
print(self.get_help(ctx))
log.print(self.get_help(ctx))

ctx.exit()

cmd_groups = self.repeat_read_commands(used_cmds, cmd_groups)
Expand Down
2 changes: 1 addition & 1 deletion esptool/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"write_mem",
]

__version__ = "5.0.2"
__version__ = "5.0.3"

import os
import shlex
Expand Down