Merge branch 'fix/fix_check_name_lenght' into 'main'

fix: fix checking max name length

See merge request espressif/idf-component-manager!511

Author: xastap00

idf_component_manager/cli/validations.py

@@ -1,4 +1,4 @@
-# SPDX-FileCopyrightText: 2024 Espressif Systems (Shanghai) CO LTD
+# SPDX-FileCopyrightText: 2024-2025 Espressif Systems (Shanghai) CO LTD
 # SPDX-License-Identifier: Apache-2.0
 import re
 from pathlib import Path
@@ -10,7 +10,7 @@
 from idf_component_tools.archive_tools import ArchiveError, get_format_from_path
 from idf_component_tools.constants import COMPILED_COMMIT_ID_RE, COMPILED_GIT_URL_RE
 from idf_component_tools.manifest import WEB_DEPENDENCY_REGEX
-from idf_component_tools.manifest.constants import SLUG_REGEX
+from idf_component_tools.manifest.constants import MAX_NAME_LENGTH, SLUG_REGEX
 from idf_component_tools.semver import Version
 from idf_component_tools.semver.base import SimpleSpec
 
@@ -19,10 +19,11 @@ def validate_name(ctx, param, value):  # noqa: ARG001
     if value is not None:
         name = value.lower()
 
-        if not re.match(SLUG_REGEX, name):
+        if len(name) > MAX_NAME_LENGTH or not re.match(SLUG_REGEX, name):
             raise click.BadParameter(
-                f'"{name}" should consist of 2 or more letters, numbers, "-" or "_". '
-                'It cannot start or end with "_" or "-", or have sequences of these characters.'
+                f'"{name}" must be between 2 and {MAX_NAME_LENGTH} characters long, '
+                'consist of letters, numbers, "-" or "_", and cannot start or end with "_" or "-", '
+                'nor contain consecutive special characters.'
             )
         return name
 

idf_component_tools/manifest/constants.py

@@ -13,6 +13,7 @@
 FULL_SLUG_REGEX = r'^((?:{slug}/{slug})|(?:{slug}))$'.format(slug=SLUG_BODY_REGEX)
 COMPILED_FULL_SLUG_REGEX = re.compile(FULL_SLUG_REGEX)
 WEB_DEPENDENCY_REGEX = r'^((?:{slug}/{slug})|(?:{slug}))(.*)$'.format(slug=SLUG_BODY_REGEX)
+MAX_NAME_LENGTH = 64
 
 LINKS = ['repository', 'documentation', 'issues', 'discussion', 'url']
 KNOWN_INFO_METADATA_FIELDS = [

tests/cli/test_validations.py

@@ -1,4 +1,4 @@
-# SPDX-FileCopyrightText: 2024 Espressif Systems (Shanghai) CO LTD
+# SPDX-FileCopyrightText: 2024-2025 Espressif Systems (Shanghai) CO LTD
 # SPDX-License-Identifier: Apache-2.0
 
 import click
@@ -24,10 +24,18 @@ def test_validate_name():
     assert validate_name(None, None, 'valid') == 'valid'
 
 
-def test_validate_name_invalid_input():
+@pytest.mark.parametrize(
+    'invalid_name',
+    [
+        't',
+        't' * 65,
+        'тест',
+    ],
+)
+def test_validate_name_invalid_input(invalid_name):
     with pytest.raises(click.BadParameter) as exc_info:
-        validate_name(None, None, 'a')
-    assert 'should consist of 2 or more letters, numbers' in str(exc_info.value)
+        validate_name(None, None, invalid_name)
+    assert 'must be between 2 and 64 characters long' in str(exc_info.value)
 
 
 def test_validate_existing_dir(tmp_path):