Skip to content

Commit 39c0447

Browse files
committed
docs: Revert all changes in those code files
1 parent 4ec9db2 commit 39c0447

File tree

10 files changed

+31
-13
lines changed

10 files changed

+31
-13
lines changed

.codespellrc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
[codespell]
2+
skip = _build
3+
ignore-words-list = laf,OT, hart,EHEN,targetIn,dout,DOUT,oen,OEN,EMAC,emac,doubleClick,AfterAll
4+
write-changes = true

.github/workflows/pre-commit.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,12 @@ jobs:
2222
- name: Install pre-commit
2323
run: pip install pre-commit
2424

25+
- name: Install codespell
26+
run: pip install codespell
27+
28+
- name: Run codespell
29+
run: codespell
30+
2531
- name: Validate commit messages
2632
run: |
2733
if [ "${{ github.event_name }}" = "pull_request" ]; then

.pre-commit-config.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,12 @@
99
rev: v1.2.1
1010
hooks:
1111
- id: conventional-precommit-linter
12-
stages: [commit-msg]
12+
stages: [commit-msg]
13+
14+
- repo: https://github.com/codespell-project/codespell
15+
rev: v2.4.1
16+
hooks:
17+
- id: codespell
18+
stages: [pre-commit]
19+
args: [--config=.codespellrc]
20+
files: ^.*\.(py|c|h|md|rst|yml)$

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ Fix: Window -> Preferences -> Plug-in Development -> API Baselines -> Missing AP
2929

3030
![image](https://github.com/espressif/idf-eclipse-plugin/assets/69584713/0a879d4f-99e2-4d5a-98ca-a745a6683752)
3131

32-
Fix: in "Project Explorer" -> com.espressif.idf.tests -> com.espressif.idf.ui.test -> META-INF -> doubleclick MANIFEST.MF -> Dependencies -> Add... -> Type "slf4j.api" -> Add&Save.
32+
Fix: in "Project Explorer" -> com.espressif.idf.tests -> com.espressif.idf.ui.test -> META-INF -> double-click MANIFEST.MF -> Dependencies -> Add... -> Type "slf4j.api" -> Add&Save.
3333

34-
* After importing project Eclipse might prompt a wizard to install `Maven Plugin Connectors` to resolve the idf-eclipse-plugins maven errors, make sure you install all of them. But, depending on the version(Eclipse / Extentions), an error may occur:
34+
* After importing project Eclipse might prompt a wizard to install `Maven Plugin Connectors` to resolve the idf-eclipse-plugins maven errors, make sure you install all of them. But, depending on the version(Eclipse / Extensions), an error may occur:
3535

3636
![image](https://github.com/espressif/idf-eclipse-plugin/assets/69584713/048196c9-8ac6-4f10-8095-596ab2ef05f2)
3737

38-
Fix: check the error and delete one of the extention (usually Tycho) - Help -> Install New Software -> Already Installed -> select "Tycho" -> Uninstall.
38+
Fix: check the error and delete one of the extension (usually Tycho) - Help -> Install New Software -> Already Installed -> select "Tycho" -> Uninstall.
3939

4040
* Run as -> SWTBot Test -> may lead to error:
4141

@@ -50,7 +50,7 @@ Fix: Uninstall SWTBot -> Install latest snapshot(04.04.2023): http://download.ec
5050
* Make changes locally on a specific local branch
5151
* Test with Maven Tycho using `$ mvn clean verify -Djarsigner.skip=true`
5252
* Submit a Pull Request(PR)
53-
* It is also recommended that you add or update a Functional Test if you are adding or updating a functionality in plugin. More details about adding SWTBot Funtional test can be found in the README.md in test folder in the repo.
53+
* It is also recommended that you add or update a Functional Test if you are adding or updating a functionality in plugin. More details about adding SWTBot Functional test can be found in the README.md in test folder in the repo.
5454

5555
## Coding Standards and guidelines
5656
* Code formatter https://github.com/espressif/idf-eclipse-plugin/blob/master/resources/espressif_eclipse_formatter.xml

docs/en/openocddebugging.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ Points 4 - 6 are shown below.
5757
.. image:: ../../media/OpenOCDDebug_6.png
5858

5959
.. note::
60-
Update the OpenOCD Config options based on the esp board you've choosen. Please check this `here <https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/jtag-debugging/tips-and-quirks.html#id1>`_.
60+
Update the OpenOCD Config options based on the esp board you've chosen. Please check this `here <https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/jtag-debugging/tips-and-quirks.html#id1>`_.
6161

6262
Startup Tab
6363
-----------

docs_readme/Espressif-IDE-Windows-Installer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ The installer deploys the following components:
1313
- Espressif-IDE
1414
- Amazon Corretto OpenJDK
1515

16-
As Installer bundles, all the required components and tools including stable esp-idf so people behind corporate firewalls can use the whole solution out-of-box. This also configures all the required build environment variables and tool paths as you launch the IDE. All you could do is to get started with your project direclty without manually configuring anything. This will give you a big boost to your productivity!
16+
As Installer bundles, all the required components and tools including stable esp-idf so people behind corporate firewalls can use the whole solution out-of-box. This also configures all the required build environment variables and tool paths as you launch the IDE. All you could do is to get started with your project directly without manually configuring anything. This will give you a big boost to your productivity!
1717

1818
More details about the standard setup of toolchain for Windows can be found in the [windows-setup](https://docs.espressif.com/projects/esp-idf/en/latest/esp32/get-started/windows-setup.html).
1919

docs_readme/JTAG Flashing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ After doing this, update the `OPENOCD_SCRIPT` environment variable in the eclips
2828

2929
* Go to `Eclipse > Preferences > C/C++ > Build > Environment`
3030
* Edit `OPENOCD_SCRIPTS` variable by providing the right path to the `openocd/scripts` folder
31-
* As a result, the path to the OpenOCD scipts may look like this: `.../.espressif/tools/openocd-esp32/v0.10.0-esp32-20201202/openocd-esp32/share/openocd/scripts`
31+
* As a result, the path to the OpenOCD scripts may look like this: `.../.espressif/tools/openocd-esp32/v0.10.0-esp32-20201202/openocd-esp32/share/openocd/scripts`

docs_readme/MissingToolsManualPathUpdateGuide.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Some tools are required as mandatory for the IDF and must be installed manually or must be selected when you are using the tools installation wizard on Linux and MAC and only selected recommended tools for windows these tools installation are mandatory and are selected with recommended tools.
44

55
If you have these tools already present on your system you can skip the first step and continue from the second step.
6-
1. In case you want to manually install these tools to the system first please vist [this](https://docs.espressif.com/projects/esp-idf/en/latest/esp32/get-started/linux-macos-setup.html) link to install them respective to your platform.
6+
1. In case you want to manually install these tools to the system first please visit [this](https://docs.espressif.com/projects/esp-idf/en/latest/esp32/get-started/linux-macos-setup.html) link to install them respective to your platform.
77

88
*Once you have installed the required tools you can move to the next step.
99
The `PATH` in the IDE is independent of the system's `PATH` variable so we need to configure it.<br/>*

docs_readme/OpenOCD Debugging.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ Let's take a look at some other options, that you need to check if they auto con
4343
Points 4 - 6 are shown below.
4444
![](images/OpenOCDDebug_6.png)
4545

46-
> **NOTE:** Update the OpenOCD Config options based on the esp board you've choosen. Please check this here https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/jtag-debugging/tips-and-quirks.html#id1
46+
> **NOTE:** Update the OpenOCD Config options based on the esp board you've chosen. Please check this here https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/jtag-debugging/tips-and-quirks.html#id1
4747
4848
## Startup Tab
4949

tests/com.espressif.idf.ui.test/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ These files were added so they can be compared with the file being created by a
2424
The configs directory contains the default-configs required for the tests they contain some configuration like build delay and some other UI awaiting delays can be added here as well, the idea is to keep only the default baseline configs here and if a functionality is taking some extensive UI operations that are not part of default operations, we can introduce another property file to contain those configurations. Currently this contains a setting for the build delay required and some absolute paths that are not relative to the repository or a central location we will try to update this once the CI for the automation is complete and the updated version of this document will contain isntructions on them. For now if your test needs to contain a property use this file and use the `**DefaultPropertyFetcher.java**` for fetching that property, for paths you can use the path on your own local env for the moment, also make sure to update these paths when you are trying to run the test.
2525

2626
### Test Classes
27-
Test cases themselves are to be placed in the `**com.espressif.idf.tests.exectuables.cases**` package. They can be further subdivided into their own packages in this package based upon the functionality they are testing for example at the time of writing this following packages are present that contain different test executable classes.
27+
Test cases themselves are to be placed in the `**com.espressif.idf.tests.executables.cases**` package. They can be further subdivided into their own packages in this package based upon the functionality they are testing for example at the time of writing this following packages are present that contain different test executable classes.
2828
![](doc/images/test_executable_packages.png)
2929

3030

@@ -66,7 +66,7 @@ Make sure to click on `Validate Plug-ins` button to see if there are any issues
6666
If there is no issue with your eclipse or SWTBot installation you should be able to run your test using the configuration.
6767

6868
### Using JUnit Runner Launch Config
69-
At times we need to debug the tests and for some issues in the SWTBot API you will get the exception of `WidgetNotFound` during debug which is because the SWTBot is dependent on UI focus a lot and during a test run if you are using the machine and the test instance of eclipse looses focus it gives that exception during debug we have to make sure that breakpoints are properly placed so that during UI interaction the test instance stays in focus. The SWTBot Runner config in eclipse for me prior to eclipse 2021-06 alway gave issues during debug so I had to use the JUnit Runner Launch Config.
69+
At times we need to debug the tests and for some issues in the SWTBot API you will get the exception of `WidgetNotFound` during debug which is because the SWTBot is dependent on UI focus a lot and during a test run if you are using the machine and the test instance of eclipse looses focus it gives that exception during debug we have to make sure that breakpoints are properly placed so that during UI interaction the test instance stays in focus. The SWTBot Runner config in eclipse for me prior to eclipse 2021-06 always gave issues during debug so I had to use the JUnit Runner Launch Config.
7070

7171
You can generate this launch config simply by right clicking on your test class and from context menu select `Run As` in the sub menu select the option `JUnit Plug-in Test`.
7272

@@ -77,5 +77,5 @@ This will start execution of your test but just like SWTBot there are a few thin
7777
Now from launch configurations in the Eclipse CDT Launchbar click on edit button next to the launch configuration name which is just added.
7878
![](doc/images/launch_config_edit_junit.png)
7979

80-
From the opened screen you can see some settings. First thing to make sure is that you use **JUnit4** from the `Test runner:` drop down. Alos make sure that `Run in UI thread` is unchecked.
80+
From the opened screen you can see some settings. First thing to make sure is that you use **JUnit4** from the `Test runner:` drop down. Also make sure that `Run in UI thread` is unchecked.
8181
Now headover to the `Plug-ins` tab and follow the same configuration steps as you did for SWTBot Launch Config

0 commit comments

Comments
 (0)