IEP-1746 Fix IllegalStateException in ActiveLaunchConfigurationProvider when JobManager is suspended (#1432)

* fix: remove ActiveLaunchConfigurationProvider to fix crash

* fix: removed ActiveLaunchConfProvider from executor

Author: sigmaaa

bundles/com.espressif.idf.core/META-INF/MANIFEST.MF

@@ -63,6 +63,7 @@ Bundle-ClassPath: .,
  lib/commons-compress-1.21.jar,
  lib/xz-1.9.jar
 Import-Package: org.apache.commons.logging,
+ org.eclipse.cdt.debug.core,
  org.eclipse.cdt.debug.core.launch,
  org.eclipse.embedcdt.core,
  org.eclipse.ui.console

bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/ActiveLaunchConfigurationProvider.java

@@ -93,7 +93,6 @@
 public class IDFBuildConfiguration extends CBuildConfiguration
 {
 
-	private static final ActiveLaunchConfigurationProvider LAUNCH_CONFIG_PROVIDER = new ActiveLaunchConfigurationProvider();
 	private static final String NINJA = "Ninja"; //$NON-NLS-1$
 	protected static final String COMPILE_COMMANDS_JSON = "compile_commands.json"; //$NON-NLS-1$
 	protected static final String COMPONENTS = "components"; //$NON-NLS-1$
@@ -190,16 +189,29 @@ public String getProperty(String name)
 	{
 		try
 		{
-			ILaunchConfiguration configuration = LAUNCH_CONFIG_PROVIDER.getActiveLaunchConfiguration();
-			if (configuration != null
-					&& configuration.getType().getIdentifier().equals(IDFLaunchConstants.DEBUG_LAUNCH_CONFIG_TYPE))
+			ILaunchBarManager launchBarManager = IDFCorePlugin.getService(ILaunchBarManager.class);
+			ILaunchConfiguration configuration = null;
+
+			if (launchBarManager != null)
+			{
+				configuration = launchBarManager.getActiveLaunchConfiguration();
+			}
+
+			if (configuration == null)
+			{
+				Logger.log("Warning: Launch Bar not ready. Falling back to default properties for " + name); //$NON-NLS-1$
+				return super.getProperty(name);
+			}
+
+			if (configuration.getType().getIdentifier().equals(IDFLaunchConstants.DEBUG_LAUNCH_CONFIG_TYPE))
 			{
 				configuration = new LaunchUtil(DebugPlugin.getDefault().getLaunchManager())
 						.getBoundConfiguration(configuration);
 			}
-			String property = configuration == null ? StringUtil.EMPTY
-					: configuration.getAttribute(name, StringUtil.EMPTY);
+
+			String property = configuration.getAttribute(name, StringUtil.EMPTY);
 			property = property.isBlank() ? getSettings().get(name, StringUtil.EMPTY) : property;
+
 			return property;
 		}
 		catch (CoreException e)

bundles/com.espressif.idf.core/src/com/espressif/idf/core/build/IDFBuildConfiguration.java

@@ -21,13 +21,13 @@
 import org.eclipse.debug.core.DebugPlugin;
 import org.eclipse.debug.core.ILaunchConfiguration;
 import org.eclipse.debug.core.ILaunchManager;
+import org.eclipse.launchbar.core.ILaunchBarManager;
 import org.eclipse.ui.console.MessageConsole;
 import org.eclipse.ui.console.MessageConsoleStream;
 
 import com.espressif.idf.core.IDFCorePlugin;
 import com.espressif.idf.core.IDFEnvironmentVariables;
 import com.espressif.idf.core.ProcessBuilderFactory;
-import com.espressif.idf.core.build.ActiveLaunchConfigurationProvider;
 import com.espressif.idf.core.build.IDFLaunchConstants;
 import com.espressif.idf.core.logging.Logger;
 
@@ -36,8 +36,7 @@ public class IdfCommandExecutor
 
 	private final String target;
 	private final MessageConsole console;
-	private static final String CMAKE_ARGUMENTS = "cmake.arguments"; //$NON-NLS-1$
-	private static final ActiveLaunchConfigurationProvider LAUNCH_CONFIG_PROVIDER = new ActiveLaunchConfigurationProvider();
+
 
 	public IdfCommandExecutor(String target, MessageConsole console)
 	{
@@ -100,7 +99,14 @@ public String getProperty(String name)
 	{
 		try
 		{
-			ILaunchConfiguration configuration = LAUNCH_CONFIG_PROVIDER.getActiveLaunchConfiguration();
+			ILaunchBarManager launchBarManager = IDFCorePlugin.getService(ILaunchBarManager.class);
+			ILaunchConfiguration configuration = null;
+
+			if (launchBarManager != null)
+			{
+				configuration = launchBarManager.getActiveLaunchConfiguration();
+			}
+
 			if (configuration != null
 					&& configuration.getType().getIdentifier().equals(IDFLaunchConstants.DEBUG_LAUNCH_CONFIG_TYPE))
 			{