Skip to content

Commit 8bd0164

Browse files
authored
adding debug information and updated key pass and src key pass for cert to debug issues (#1330)
1 parent 0cade9d commit 8bd0164

File tree

1 file changed

+21
-4
lines changed

1 file changed

+21
-4
lines changed

.github/workflows/ci_release.yml

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,22 +173,39 @@ jobs:
173173
-srckeystore mykeystore.jks `
174174
-srcstorepass $env:JKS_PASS `
175175
-srcalias $env:ALIAS `
176+
-srckeypass $env:JKS_PASS `
176177
-destkeystore cert.pfx `
177178
-deststoretype PKCS12 `
178-
-deststorepass $env:PFX_PASS
179+
-deststorepass $env:PFX_PASS `
180+
-destkeypass $env:PFX_PASS
181+
182+
- name: Inspect the PFX file
183+
shell: pwsh
184+
run: |
185+
certutil -p $env:PFX_PASS -dump cert.pfx
179186
180187
- name: Sign Windows Executable
181188
shell: pwsh
182189
run: |
183190
$exe = Get-ChildItem -Recurse extracted\Espressif-IDE\espressif-ide.exe | Select-Object -First 1
184-
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits" -Recurse -Name "signtool.exe" | Select-Object -First 1
185-
& "C:\Program Files (x86)\Windows Kits\$signtool" sign `
191+
if (-not $exe) { throw "espressif-ide.exe not found under extracted\Espressif-IDE" }
192+
193+
$signtool = Get-ChildItem "C:\Program Files (x86)\Windows Kits" -Recurse -Filter signtool.exe |
194+
Sort-Object FullName | Select-Object -First 1
195+
196+
if (-not $signtool) { throw "signtool.exe not found in Windows Kits" }
197+
198+
if (-not (Test-Path "$PWD\cert.pfx")) { throw "cert.pfx not found in $PWD" }
199+
200+
& $signtool.FullName sign `
201+
/debug `
202+
/v `
186203
/f cert.pfx `
187204
/p $env:PFX_PASS `
188205
/tr http://timestamp.digicert.com `
189206
/td sha256 `
190207
/fd sha256 `
191-
$exe.FullName
208+
"$($exe.FullName)"
192209
193210
- name: Verify Signature
194211
run: |

0 commit comments

Comments
 (0)