Skip to content

Commit e70f1a2

Browse files
committed
Revert "adding some debug information for signing"
This reverts commit 609fd7b.
1 parent 609fd7b commit e70f1a2

File tree

1 file changed

+4
-21
lines changed

1 file changed

+4
-21
lines changed

.github/workflows/ci_release.yml

Lines changed: 4 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -173,39 +173,22 @@ jobs:
173173
-srckeystore mykeystore.jks `
174174
-srcstorepass $env:JKS_PASS `
175175
-srcalias $env:ALIAS `
176-
-srckeypass $env:JKS_PASS `
177176
-destkeystore cert.pfx `
178177
-deststoretype PKCS12 `
179-
-deststorepass $env:PFX_PASS `
180-
-destkeypass $env:PFX_PASS
181-
182-
- name: Inspect the PFX file
183-
shell: pwsh
184-
run: |
185-
certutil -p $env:PFX_PASS -dump cert.pfx
178+
-deststorepass $env:PFX_PASS
186179
187180
- name: Sign Windows Executable
188181
shell: pwsh
189182
run: |
190183
$exe = Get-ChildItem -Recurse extracted\Espressif-IDE\espressif-ide.exe | Select-Object -First 1
191-
if (-not $exe) { throw "espressif-ide.exe not found under extracted\Espressif-IDE" }
192-
193-
$signtool = Get-ChildItem "C:\Program Files (x86)\Windows Kits" -Recurse -Filter signtool.exe |
194-
Sort-Object FullName | Select-Object -First 1
195-
196-
if (-not $signtool) { throw "signtool.exe not found in Windows Kits" }
197-
198-
if (-not (Test-Path "$PWD\cert.pfx")) { throw "cert.pfx not found in $PWD" }
199-
200-
& $signtool.FullName sign `
201-
/debug `
202-
/v `
184+
$signtool = Get-ChildItem -Path "C:\Program Files (x86)\Windows Kits" -Recurse -Name "signtool.exe" | Select-Object -First 1
185+
& "C:\Program Files (x86)\Windows Kits\$signtool" sign `
203186
/f cert.pfx `
204187
/p $env:PFX_PASS `
205188
/tr http://timestamp.digicert.com `
206189
/td sha256 `
207190
/fd sha256 `
208-
"$($exe.FullName)"
191+
$exe.FullName
209192
210193
- name: Verify Signature
211194
run: |

0 commit comments

Comments
 (0)