-
Notifications
You must be signed in to change notification settings - Fork 133
Docs/translate windowsofflineinstaller.rst & debugproject.rst #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @April-Yjj @leeebo PTAL, thx! |
April-Yjj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Shen7436 Overall LGTM! Just some nitpicks.
b3e5c05 to
406b932
Compare
kolipakakondal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Shen7436 Please check the review comments.
leeebo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shen7436 LGTM!
9ac371d to
db7e7d7
Compare
db7e7d7 to
0b9061e
Compare
0b9061e to
12940d5
Compare
This PR:
windowsofflineinstaller.rstanddebugproject.rstin the docs/en folder based on Espressif Style Guide.