-
Notifications
You must be signed in to change notification settings - Fork 133
docs: Provide CN translation for three docs #1348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Provide CN translation for three docs #1348
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kolipakakondal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we just need to adopt a few changes considering the EIM integration.
fb351f4 to
591e91a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Shen7436, the translation LGTM! Left one comment. Besides, I have a few suggestions regarding the webpage. @kolipakakondal PTAL. Thank you!
- Update the copyright information in the footer. It currently shows "2016 - 2024".
- Organize the files according to the structure of the deployed webpage’s TOC. For example, configureenvvariables.rst belongs under Installation > References, not Additional IDE Features. Using hyphens or underscores to separate words in filenames would also help improve clarity and make future maintenance easier.
leeebo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shen7436 LGTM!
591e91a to
272b8b0
Compare
272b8b0 to
ca221a3
Compare
Yes, some of the relevant documents we can move like as you mentioned Installation > References and few others. We can still maintain "Additional IDE Features" section to keep the features such as Application Size analysis, ESP-IDF Terminal, etc. We are maintaining the same TOC for VSCode and Eclipse as of now. |
This PR:
lspeditor.rst,writebinarytoflash.rst,configureenvvariables.rstin the docs/en/additionalfeatures folder based on Espressif Style Guide.